Better README. Renamed Env Variables to be more specific #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thehcma
reviewed
May 2, 2018
README.md
Outdated
|
|
||
| Options: | ||
|
|
||
| --chrome-version [chromeVersion] Chrome browser major version string e.g. 65 |
There was a problem hiding this comment.
..., e.g.,... (the comma pre/post is a weird English grammar rule)
thehcma
reviewed
May 2, 2018
README.md
Outdated
| --chrome-version [chromeVersion] Chrome browser major version string e.g. 65 | ||
| --chrome-driver-target-path [chromeDriverTargetPath] Path to install Chrome driver executable | ||
| --firefox-version [firefoxVersion] Firefox browser major version string e.g. 57 | ||
| --firefox-driver-target-path [firefoxDriverTargetPath] Path to install Firefox driver(geckoDriver) executable |
There was a problem hiding this comment.
space after driver
looks like the preferred spelling for the name of the driver is geckodriver
added 12 commits
May 3, 2018 09:58
thehcma
reviewed
May 3, 2018
| installer.driverInstaller('chrome', wrongVersionNumber, | ||
| '/some/target/path'); | ||
| }).to.throw( | ||
| /Failed to locate a version of chromedriver that matches the installed version of chrome \(1\). Valid chrome versions are:*/ |
thehcma
reviewed
May 3, 2018
| env: | ||
| global: | ||
| - BROWSER_DRIVER_INSTALLER_CHROME_VERSION=67 |
There was a problem hiding this comment.
ideally, we could have an alias for the latest version, so we don't need to hard code this here (assuming, that is, this is possible) and we wouldn't have to change the versions here also
thehcma
reviewed
May 3, 2018
|
|
||
| Options: | ||
|
|
||
| --browser-name <browserName> Browser to install the driver for |
There was a problem hiding this comment.
in our command-line tools we do: "sets " and -h "outputs..."
thehcma
approved these changes
May 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.