Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ipinfo_io_whois.c #116

Closed
wants to merge 3 commits into from
Closed

Conversation

revrsefr
Copy link
Contributor

I removed the old ipinfo_whois file and removed the curl things to use unrealircd API.

@syzop
Copy link
Member

syzop commented Jul 18, 2024

Do you still want this merged? I ask because in 6.1.7+ we added ASN, and we already had country earlier.

@revrsefr revrsefr closed this Jul 18, 2024
syzop added a commit that referenced this pull request Sep 1, 2024
This functionality is provided in UnrealIRCd itself using the
GeoIP API. UnrealIRCd 6.1.7 now supports "ASN" (which this
module provided as "org" I think) and we already had support
for "country". Ok, "region" / "city" is missing, but other
than that...

See #116
which was closed after asking if we still needed this.
Just didn't realize the old module was still in the repo...
@syzop
Copy link
Member

syzop commented Sep 1, 2024

When this was closed (which I take as a "no, this module is no longer needed") I forgot that we still had to remove the original module third/ipinfo_io_whois.c. So I did just now, in commit b14b15f with this message:

Remove third/ipinfo_io_whois since it is no longer needed.
This functionality is provided in UnrealIRCd itself using the
GeoIP API. UnrealIRCd 6.1.7 now supports "ASN" (which this
module provided as "org" I think) and we already had support
for "country". Ok, "region" / "city" is missing, but other
than that...
See #116 which was closed after asking if we still needed this.
Just didn't realize the old module was still in the repo...

I'm happy we have the ASN support nowadays :)

The city stuff could actually be added to the geoip modules, and then you need city databases, but I don't think many people need this, and these are generally not free or freely distributable. I'm happy to add support in unrealircd for parsing and showing it in some future patch but we won't ship by default with those db files, so.. it's not exactly high on my list.. I think most people can live without "city". The "country" and now "asn" since 6.1.7 is most useful though!

@revrsefr
Copy link
Contributor Author

revrsefr commented Sep 1, 2024

whatever

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants