Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Properly scale shadow on Android #9782

Conversation

MartinZikmund
Copy link
Member

@MartinZikmund MartinZikmund commented Sep 9, 2022

GitHub Issue (If applicable): closes #9783

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@MartinZikmund MartinZikmund self-assigned this Sep 9, 2022
@MartinZikmund MartinZikmund marked this pull request as ready for review September 9, 2022 16:37
@gitpod-io
Copy link

gitpod-io bot commented Sep 9, 2022

Copy link
Contributor

@agneszitte agneszitte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MartinZikmund can we maybe add additional tests to make sure there are no more scaling issues for the shadow next time in the long run ;) ?

@MartinZikmund MartinZikmund merged commit 88d7a40 into unoplatform:master Sep 9, 2022
@MartinZikmund MartinZikmund deleted the dev/mazi/elevation-android-scale branch September 9, 2022 22:45
@jeromelaban
Copy link
Member

@Mergifyio backport release/stable/4.5

@mergify
Copy link
Contributor

mergify bot commented Sep 10, 2022

backport release/stable/4.5

✅ Backports have been created

jeromelaban added a commit that referenced this pull request Sep 10, 2022
….5/pr-9782

fix: Properly scale shadow on Android (backport #9782)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Gallery][Android] ElevatedView- Scale for shadow is not proper for Elevated view.
3 participants