Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HR: Changed the way code (XAML) is updated through Hot Reload (backport #19584) #19609

Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 27, 2025

Closes https://github.com/unoplatform/uno.hotdesign/issues/3351

Feature

The way Visual Studio is dealing with Hot Reload is by using its documents to compile and ship updated IL to the application. There is no requirement to save the file for Hot Reload to work in this environment.

That means 2 things:

  1. The file on disk may not reflect the last changes which only occurs in memory in Visual Studio. The user may save the file, but it's not a requirement for HR.
  2. If the file is opened in Visual Studio, a silent change to the file on disk may not be picked up by HR, especially when VS is not focused. THIS IS THE PROBLEM THIS PR IS ADDRESSING. The other one will be addressed afterwards (soon).

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:


This is an automatic backport of pull request #19584 done by [Mergify](https://mergify.com).

…d be forced to be saved to disk or not. Default to true for now, will change eventually.

(cherry picked from commit 26e971c)
…e 2 different operations and can both be done separately without invoking the other one.

(cherry picked from commit e57aaf5)
(cherry picked from commit afa8a3e)
…file open + save operation

(cherry picked from commit 555b0c9)
… to a constructor. Should not happen anymore.

(cherry picked from commit 8f9a717)
@github-actions github-actions bot added the area/automation Categorizes an issue or PR as relevant to project automation label Feb 27, 2025
@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19609/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19609/index.html

@jeromelaban jeromelaban merged commit fb989a1 into release/stable/5.6 Feb 27, 2025
59 of 98 checks passed
@jeromelaban jeromelaban deleted the mergify/bp/release/stable/5.6/pr-19584 branch February 27, 2025 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/automation Categorizes an issue or PR as relevant to project automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants