Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(CTK8): Added converters usage sample #19212

Merged
merged 9 commits into from
Jan 20, 2025

Conversation

DevTKSS
Copy link
Contributor

@DevTKSS DevTKSS commented Jan 12, 2025

GitHub Issue (If applicable): closes #18669

PR Type

What kind of change does this PR introduce?

  • Documentation content changes

What is the current behavior?

currently missing in Documentation

What is the new behavior?

added missing sample

PR Checklist

Please check if your PR fulfills the following requirements:

  • Docs have been updated
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Validated PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Associated with an issue (GitHub or internal) and uses the automatic close keywords.
  • Commits must be following the Conventional Commits specification.

Other information

Replaces PR #19086 and #18726

Internal Issue (If applicable):

@unodevops
Copy link
Contributor

⚠️⚠️ The build 151745 has failed on Uno.UI - docs.

@unodevops
Copy link
Contributor

⚠️⚠️ The build 151747 has failed on Uno.UI - docs.

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19212/index.html

@DevTKSS
Copy link
Contributor Author

DevTKSS commented Jan 12, 2025

On the ci outputed page, the namespaces on settingscard and the converters, the namespace using seems like not correctly formatted, maybe a line break needed?
Inspected the preview on GitHub which is showing the same, but the raw code is not showing anything indicating that issue. Would need someone to check and maybe see that missing chars

@DevTKSS
Copy link
Contributor Author

DevTKSS commented Jan 14, 2025

@MartinZikmund moved to here, the pr history of that other branch was not clean-up able to me. The ci runned through now only problem is with the using mentioned on last comment here. I do not see why this is happening, only thing i did remove has been spaces at the line ending which would have leaded to markdown linting issues...

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19212/index.html

doc/articles/uno-community-toolkit-v8.md Outdated Show resolved Hide resolved
doc/articles/uno-community-toolkit-v8.md Outdated Show resolved Hide resolved
doc/articles/uno-community-toolkit-v8.md Outdated Show resolved Hide resolved
doc/articles/uno-community-toolkit-v8.md Outdated Show resolved Hide resolved
doc/articles/uno-community-toolkit-v8.md Outdated Show resolved Hide resolved
doc/articles/uno-community-toolkit-v8.md Outdated Show resolved Hide resolved
doc/articles/uno-community-toolkit-v8.md Outdated Show resolved Hide resolved
doc/articles/uno-community-toolkit-v8.md Outdated Show resolved Hide resolved
doc/articles/uno-community-toolkit-v8.md Outdated Show resolved Hide resolved
doc/articles/uno-community-toolkit-v8.md Outdated Show resolved Hide resolved
@jeromelaban
Copy link
Member

Thanks for your contribution!

doc/articles/uno-community-toolkit-v8.md Outdated Show resolved Hide resolved
doc/articles/uno-community-toolkit-v8.md Outdated Show resolved Hide resolved
doc/articles/uno-community-toolkit-v8.md Outdated Show resolved Hide resolved
doc/articles/uno-community-toolkit-v8.md Outdated Show resolved Hide resolved
doc/articles/uno-community-toolkit-v8.md Outdated Show resolved Hide resolved
doc/articles/uno-community-toolkit-v8.md Outdated Show resolved Hide resolved
doc/articles/uno-community-toolkit-v8.md Outdated Show resolved Hide resolved
doc/articles/uno-community-toolkit-v8.md Outdated Show resolved Hide resolved
doc/articles/uno-community-toolkit-v8.md Outdated Show resolved Hide resolved
@agneszitte agneszitte self-assigned this Jan 20, 2025
@unodevops
Copy link
Contributor

⚠️⚠️ The build 152679 has failed on Uno.UI - docs.

@agneszitte
Copy link
Contributor

Thank you a lot for your contribution @DevTKSS, appreciated!

@agneszitte agneszitte enabled auto-merge January 20, 2025 21:53
@agneszitte
Copy link
Contributor

@Mergifyio backport release/stable/5.5

Copy link
Contributor

mergify bot commented Jan 20, 2025

backport release/stable/5.5

❌ No backport have been created

  • Backport to branch release/stable/5.5 failed

Git reported the following error:

error: commit 88301e2e7765a507b3465f33bfba32c766680ae9 is a merge but no -m option was given.
fatal: cherry-pick failed

@agneszitte
Copy link
Contributor

@Mergifyio backport release/stable/5.6

Copy link
Contributor

mergify bot commented Jan 20, 2025

backport release/stable/5.6

❌ No backport have been created

  • Backport to branch release/stable/5.6 failed

Git reported the following error:

error: commit 88301e2e7765a507b3465f33bfba32c766680ae9 is a merge but no -m option was given.
fatal: cherry-pick failed

@agneszitte agneszitte merged commit 77e5945 into unoplatform:master Jan 20, 2025
16 checks passed
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19212/index.html

@unoplatform unoplatform deleted a comment from unodevops Jan 20, 2025
agneszitte added a commit that referenced this pull request Jan 21, 2025
docs(CTK8): Added converters usage sample (Backport #19212)
agneszitte added a commit that referenced this pull request Jan 21, 2025
docs(CTK8): Added converters usage sample (Backport #19212)
@sasakrsmanovic
Copy link
Contributor

Thanks for the contribution and congrats on another PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Content / Link to Converters chapter pointing to Community Toolkit
5 participants