feat(macOS): add native elements support for macOS/Skia #18793
Conversation
|
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18793/index.html |
| @@ -15,7 +15,7 @@ internal static class MacOSMetalRenderer | |||
| // FIXME: contribute some extra API (e.g. using `nint` or `IntPtr`) to SkiaSharp to avoid reflection | |||
| // net8+ alternative -> https://steven-giesel.com/blogPost/05ecdd16-8dc4-490f-b1cf-780c994346a4 | |||
| var get = typeof(GRContext).GetMethod("GetObject", BindingFlags.Static | BindingFlags.NonPublic); | |||
There was a problem hiding this comment.
Heads up: I compiled SkiaSharp 3 a while ago to try it with Uno and this blew up in my face. I think they may have removed GetObject or something. The software renderer worked though.
There was a problem hiding this comment.
thanks, I'll PR something to SkiaSharp so that reflection is not needed for 3.x
| { | ||
| if (element.Detached) | ||
| { | ||
| this.Log().Debug($"Cannot arrange element `{nameof(content)}` of type {content.GetType().FullName} since it was detached."); |
There was a problem hiding this comment.
Maybe also a Debug.Assert?
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18793/index.html |
|
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18793/index.html |
GitHub Issue (If applicable): closes #
PR Type
What kind of change does this PR introduce?
What is the current behavior?
It is not possible to use native controls inside a Skia-based app on macOS.
What is the new behavior?
It's now possible to integrate native controls (some code required) inside Skia-based apps on macOS.
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):
https://github.com/unoplatform/uno-private/issues/479