fix: android maincommand tint #1339
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajamatt
force-pushed
the
dev/mara/fix-android-maincommand
branch
from
3dfbb05 to
dd00fd9
Compare
rajamatt
force-pushed
the
dev/mara/fix-android-maincommand
branch
from
875ba08 to
fc7b45a
Compare
rajamatt
commented
Feb 11, 2025
| @@ -84,7 +84,7 @@ protected override void Render() | |||
|
|
|||
| // Foreground | |||
| var hasIconColor = element.TryGetIconColor(out var foregroundColor); | |||
| var foregroundOpacity = hasIconColor ? foregroundColor.A / 255d : 0d; | |||
| var foregroundOpacity = hasIconColor ? foregroundColor.A / 255d : 1.0; | |||
There was a problem hiding this comment.
I think this fix is better than the last (see first commit). We can remove the TryGetColorWithOpacity() check behind the scenes. We are already getting and setting the opacity here so
(1) If the user really wants a lower opacity they can just specify it in the AppBarButton.Opacity property.
(2) If its really just the BitmapIcon's opacity that the user wants to lower it will work as before because we have this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): #closes https://github.com/unoplatform/add-private/issues/30
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The MainCommand on Android is being set a tint on-top, making it appear monochrome.
What is the new behavior?
The MainCommand will appear monochrome if specified in the BitmapIcon.ShowAsMonochrome property.
PR Checklist
Please check if your PR fulfills the following requirements:
Other information
Internal Issue (If applicable):