Remove unused Logging Condition #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeromelaban
approved these changes
Jan 24, 2024
|
@Mergifyio backport release/stable/5.1 |
✅ Backports have been created
|
dansiegel
added a commit
that referenced
this pull request
Jan 24, 2024
…1/pr-516 Remove unused Logging Condition (backport #516)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): closes #
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The template includes an unused condition for NETFX_CORE which came from the legacy template but is not defined.
What is the new behavior?
As WinAppSdk already uses the Console Logger there is no reason to switch this to the Debug logger by default. As a result we are simply removing the
NETFX_COREcondition with the Debug Logger