Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow vscode w/dev kit to load solutions made from template #494

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

spouliot
Copy link
Contributor

GitHub Issue (If applicable): closes #

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

VS Code with OmniSharp can load the solution create from the templates.

VS Code with C# DevKit can NOT load the solution create from the templates. In this case a notification is shown

Failed to restore solution.

and the logs shows

  Determining projects to restore...
/usr/local/share/dotnet/sdk/8.0.100/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(90,5): error NETSDK1100: To build a project targeting Windows on this operating system, set the EnableWindowsTargeting property to true. [/Users/poupou/git/external/uno/Uno.Samples/reference/SimpleCalc/MVU-X-CSharp/SimpleCalculator.Windows/SimpleCalculator.Windows.csproj]

What is the new behavior?

VS Code can load the solution in either OmniSharp or Dev Kit modes.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@jeromelaban
Copy link
Member

@Mergifyio backport release/stable/5.0

Copy link

mergify bot commented Dec 19, 2023

backport release/stable/5.0

✅ Backports have been created

@jeromelaban jeromelaban merged commit d41d0c1 into main Dec 20, 2023
40 checks passed
@jeromelaban jeromelaban deleted the EnableWindowsTargeting branch December 20, 2023 04:27
jeromelaban added a commit that referenced this pull request Dec 20, 2023
…0/pr-494

fix: allow vscode w/dev kit to load solutions made from template (backport #494)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants