-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Ensure Fluent resources for AutoSuggestBox on WASM #1173
fix: Ensure Fluent resources for AutoSuggestBox on WASM #1173
Conversation
@morning4coffe-dev have a look, now it is applying Fluent to all AutosuggestBox |
Thank you, @mcNets! Looks good. Could you check an error |
GetTemplateChild on Windows uses Uno.Themes / GetTemplateChild extension class instead of Microsoft.UI.Xaml.Controls.
@morning4coffe-dev windows head works fine without ensuring xaml resources so I used a conditional. I don't know why Windows head is using the extension class in |
Co-authored-by: Dominik Titl <[email protected]>
Congrats on your first pull-request! We ❤ the people who are involved in this project, and we’d love to pay it forward by sending you some swag. If you have any feedback (or ideas how to improve Uno as a open-source project) please open a feedback issue. |
Thank you @mcNets again for helping on this and for your contribution! |
@morning4coffe-dev thank you for your help. |
GitHub Issue (If applicable): closes #
unoplatform/uno#15967
PR Type
What kind of change does this PR introduce?
Forces Fluent style on AutosuggestBox popup in Wasm.
What is the current behavior?
Autosuggest box has Material styles applied.
What is the new behavior?
When the page loads gets the Border's popup control via
GetTemplateChild
and appliesEnsureXamlControlsResources()
method.PR Checklist
Please check if your PR fulfills the following requirements:
Other information
I got the name of the Border from the microsoft repo.
https://github.com/microsoft/microsoft-ui-xaml/blob/d74a0332cf0d5e58f12eddce1070fa7a79b4c2db/src/controls/dev/AutoSuggestBox/AutoSuggestBoxHelper.cpp#L8-L13
Internal Issue (If applicable):
unoplatform/uno#15967