Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Improve search experience #1124

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Conversation

morning4coffe-dev
Copy link
Member

@morning4coffe-dev morning4coffe-dev commented Jun 19, 2024

GitHub Issue (If applicable): closes #1122

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

What is the new behavior?

fix search result visuals

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested on iOS.
  • Tested on Wasm.
  • Tested on Android.
  • Tested on UWP.
  • Tested in both Light and Dark themes.
  • Associated with an issue (GitHub or internal)

Other information

part of #1122

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-1124.eastus2.3.azurestaticapps.net

@MartinZikmund
Copy link
Member

@agneszitte can you merge this?

@Xiaoy312
Copy link
Contributor

the ui tests have been repeatedly failing, for 4 reruns
can you verify locally that everything is still fine?

@morning4coffe-dev
Copy link
Member Author

@Xiaoy312 I think this issue with the CI is coming from master, but I think we discussed with @agneszitte last week on different issue with the same error, it should be ok to merge. I am unfortunately not able to test on iOS / macOS.

Copy link

github-actions bot commented Jul 1, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-1124.eastus2.3.azurestaticapps.net

@MartinZikmund MartinZikmund disabled auto-merge July 1, 2024 20:41
@agneszitte agneszitte merged commit f9eacf8 into master Jul 2, 2024
14 of 16 checks passed
@agneszitte agneszitte deleted the dev/doti/adjust-search-exp branch July 2, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants