Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update appbar #1048

Merged
merged 2 commits into from
Nov 10, 2023
Merged

chore: update appbar #1048

merged 2 commits into from
Nov 10, 2023

Conversation

Xiaoy312
Copy link
Contributor

@Xiaoy312 Xiaoy312 commented Nov 8, 2023 •
edited
Loading

GitHub Issue (If applicable): closes #945

PR Type

What kind of change does this PR introduce?

  • Feature

What is the current behavior?

What is the new behavior?

Updated top appbar for wasm to be more in sync with platform.uno look&feel.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested on Wasm.
  • Tested in both Light and Dark themes.
  • Associated with an issue (GitHub or internal)

@Xiaoy312
Copy link
Contributor Author

Xiaoy312 commented Nov 8, 2023 •
edited
Loading

.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-1048.eastus2.3.azurestaticapps.net

@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20231108/appbar-revamp branch 2 times, most recently from bf2ae74 to 16e86dd Compare November 9, 2023 00:33
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-1048.eastus2.3.azurestaticapps.net

1 similar comment
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-1048.eastus2.3.azurestaticapps.net

@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20231108/appbar-revamp branch from 16e86dd to a39422c Compare November 9, 2023 03:34
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-1048.eastus2.3.azurestaticapps.net

@Xiaoy312 Xiaoy312 marked this pull request as ready for review November 9, 2023 14:12
agneszitte
agneszitte reviewed Nov 9, 2023
View reviewed changes
Copy link
Contributor

@agneszitte agneszitte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the links and details are fine, thank you a lot for the changes @Xiaoy312
Only issue I noticed is the mobile/narrow version here
Let me take a look to help you fix that
image

@agneszitte agneszitte force-pushed the dev/xygu/20231108/appbar-revamp branch from e3f6b08 to edafc47 Compare November 9, 2023 19:05
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-1048.eastus2.3.azurestaticapps.net

@agneszitte agneszitte force-pushed the dev/xygu/20231108/appbar-revamp branch from edafc47 to b642d9d Compare November 9, 2023 19:32
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-1048.eastus2.3.azurestaticapps.net

@agneszitte agneszitte force-pushed the dev/xygu/20231108/appbar-revamp branch from b642d9d to 14bbe1a Compare November 9, 2023 19:54
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-1048.eastus2.3.azurestaticapps.net

@agneszitte agneszitte force-pushed the dev/xygu/20231108/appbar-revamp branch from 14bbe1a to 9bfde68 Compare November 9, 2023 22:38
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-1048.eastus2.3.azurestaticapps.net

@agneszitte agneszitte force-pushed the dev/xygu/20231108/appbar-revamp branch from 9bfde68 to ae0a473 Compare November 9, 2023 23:21
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-1048.eastus2.3.azurestaticapps.net

@agneszitte agneszitte force-pushed the dev/xygu/20231108/appbar-revamp branch from ae0a473 to b2137a5 Compare November 9, 2023 23:37
@agneszitte agneszitte force-pushed the dev/xygu/20231108/appbar-revamp branch from b2137a5 to 873a2fe Compare November 9, 2023 23:39
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-1048.eastus2.3.azurestaticapps.net

1 similar comment
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-1048.eastus2.3.azurestaticapps.net

@agneszitte agneszitte enabled auto-merge November 10, 2023 00:04
@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@agneszitte
Copy link
Contributor

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@agneszitte agneszitte merged commit 0ed9171 into master Nov 10, 2023
15 checks passed
@agneszitte agneszitte deleted the dev/xygu/20231108/appbar-revamp branch November 10, 2023 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agneszitte agneszitte agneszitte left review comments

@sasakrsmanovic sasakrsmanovic sasakrsmanovic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Match header menu with main Uno Platform site
3 participants
@Xiaoy312 @agneszitte @sasakrsmanovic