Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: various minor parsing issues #64

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

fix: various minor parsing issues #64

wants to merge 8 commits into from

Conversation

Boy0000
Copy link
Contributor

@Boy0000 Boy0000 commented Aug 9, 2024

No description provided.

@yusshu
Copy link
Member

yusshu commented Aug 9, 2024

I think it would make more sense to just add condition in the deserializer (serializer-minecraft subproject)
How does the Minecraft client handle this?

@Boy0000 Boy0000 changed the title fix: add missing CubeFace used by Scaffolding fix: various minor parsing issues Nov 28, 2024
@Boy0000
Copy link
Contributor Author

Boy0000 commented Nov 28, 2024

For this latest you might want to make a new interface for it instead of treating it as an unknown file
as of 1.21.4 it was moved from assets/namespace/models/equipment/x.json to assets/namespace/equipment/x.json
So a EquipmentModel taking a humanoid, humanoid_leggings and so on @yusshu

yusshu added a commit that referenced this pull request Mar 12, 2025
@yusshu
fix(serializer-minecraft): fix item serialization by @Boy0000 in #64
b7c1f1a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Boy0000 @yusshu