Include fields on Exceptions, this addresses missing fields on Exception structs

[mjpizz]

We had solved this in the old version of thrift-pyi (discussion here) but this appears to be a regression in latest version.

[unmade]

Hey @mjpizz!

Thanks for bringing that up! I did rewrite a library not so long ago, but that behaviour seems to be in the old versions as well. In the result of the previous discussion we added __init__ to the exception classes, but completely forgot to add fields.

I see you have some tests failing. You can fix it by changing class NotFound... to:

class NotFound(Exception):
    message: Optional[str] = "Not Found"

    def __init__(self, message: Optional[str] = "Not Found") -> None: ...

That should be done in several places:

• tests/stubs/expected/async/shared.pyi
• tests/stubs/expected/optional/shared.pyi
• tests/stubs/expected/sync/shared.pyi

[unmade]

Also, if possible, please change version to the version = "0.6.0" in the pyproject.toml, so I can release it as soon a PR is merged

[mjpizz]

Easy enough :) made the changes, let me know when it's good to go.

[mjpizz]

@unmade what's the status on this? I think you might need to trigger the workflows since you're the maintainer.

[unmade]

Thanks for reminding me! It's been a busy week for me and I completely forgot that some actions required from my part. I'll release it today

[codecov-commenter]

Codecov Report

Patch and project coverage have no change.

Comparison is base (696b810) 100.00% compared to head (5552b58) 100.00%.

Additional details and impacted files

@@            Coverage Diff            @@
##            master       #41   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           46        46           
  Branches         5         3    -2     
=========================================
  Hits            46        46           

Flag	Coverage Δ
unittests	100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.