Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support fuse #14493

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Conversation

Supeeerpower
Copy link
Contributor

@Supeeerpower Supeeerpower commented Aug 30, 2024

Description

Deploy Unlock protocol on Fuse to support Fuse Network which is an EVM compatible Layer 1 Blockchain

Issues

Fixes #
Refs #

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

Release Note Draft Snippet

Copy link

cla-bot bot commented Aug 30, 2024

Thank you for your pull request and welcome to Unlock! We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @Supeeerpower on file.
In order for us to review and merge your code, please open another pull request with a single modification: your github username added to the file .clabot.
Thank you!

@Supeeerpower Supeeerpower marked this pull request as draft August 30, 2024 18:03
@Supeeerpower Supeeerpower marked this pull request as ready for review August 30, 2024 18:03
Copy link

cla-bot bot commented Aug 30, 2024

Thank you for your pull request and welcome to Unlock! We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @Supeeerpower on file.
In order for us to review and merge your code, please open another pull request with a single modification: your github username added to the file .clabot.
Thank you!

This reverts commit acaa3c9.
Copy link

cla-bot bot commented Aug 30, 2024

Thank you for your pull request and welcome to Unlock! We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @Supeeerpower on file.
In order for us to review and merge your code, please open another pull request with a single modification: your github username added to the file .clabot.
Thank you!

@cla-bot cla-bot bot added the cla-signed label Aug 30, 2024
},
featured: false,
fullySubsidizedGas: true,
hooks: {},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to deploy the hooks too please.

hooks: {},
id: 122,
isTestNetwork: false,
keyManagerAddress: '',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please deploy that contract as well

startBlock: 31355828,
subgraph: {
endpoint:
'https://api.studio.thegraph.com/query/87693/unlock-protocol-fuse/version/lastest', // this is given to you by the graph after deploying
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this has been deployed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@unlock-deployer
Copy link
Collaborator

packages/networks/src/networks/fuse.ts

The setup is successful :

  • ✅ all mandatory keys are present
  • ✅ Contract PublicLockLatest at 0x8C5b642ccC29676B101f8B8E8F29D2DEaF4b3e9a is verified
  • ✅ Contract Unlock at 0xbf36B2a6dd0019555A33602Bf04e2882b0cEc843 is verified
  • ✅ Subgraph up and running

We have found the following errors :

  • ❌ Unexpected policy: 1/9 for 4/9 expected
  • ❌ Unlock owner is not set to the multisig
  • ❌ Unlock Proxy Admin owner is not set to the multisig

Some verification calls have failed :

  • ❌ Could not fetch Unlock source code from block explorer, undefined
  • ❌ Could not fetch PublicLock source code from block explorer, SyntaxError: Unexpected token '/', "/ Sources "... is not valid JSON

Some additonal warnings :

  • ⚠️ Contract PublicLockPrevious is missing
  • ⚠️ Contract UDTv3 is missing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants