Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(timers): bind global functions #384

Merged
merged 7 commits into from
Jan 16, 2025
Merged

fix(timers): bind global functions #384

merged 7 commits into from
Jan 16, 2025
+18 −6

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Jan 15, 2025 •
edited
Loading

Co-authored-by: Yagiz Nizipli [email protected]

Found while debugging mysql2 on workers

This is part 1 of 2 in a stack made with GitButler:

@vicb vicb requested review from a team and pi0 as code owners January 15, 2025 19:24
@vicb
Copy link
Contributor Author

vicb commented Jan 16, 2025

Good catch, thanks Pooya!

@vicb vicb requested a review from pi0 January 16, 2025 05:58
@vicb vicb mentioned this pull request Jan 16, 2025
Merged
@pi0 pi0 merged commit 3caf1f3 into main Jan 16, 2025
2 checks passed
@pi0 pi0 deleted the timers-bind branch January 16, 2025 22:13
@workers-devprod workers-devprod mentioned this pull request Jan 20, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

@anonrig anonrig anonrig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vicb @anonrig @pi0