Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(event-handler): provide clarity on package #951

Merged
merged 1 commit into from
Jan 19, 2025

Conversation

iiio2
Copy link
Contributor

@iiio2 iiio2 commented Jan 14, 2025

actually example-node-middleware does not exist. I have given a comment on it so that it provides clarity like this for "web-handler" (https://h3.unjs.io/guide/event-handler#converting-from-web-handlers).

@iiio2 iiio2 requested a review from pi0 as a code owner January 14, 2025 06:00
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.99%. Comparing base (a58d7c9) to head (609ff65).
Report is 211 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #951      +/-   ##
==========================================
+ Coverage   77.83%   78.99%   +1.15%     
==========================================
  Files          47       43       -4     
  Lines        4286     3237    -1049     
  Branches      611      795     +184     
==========================================
- Hits         3336     2557     -779     
+ Misses        933      677     -256     
+ Partials       17        3      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@nozomuikuta nozomuikuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@nozomuikuta nozomuikuta merged commit 5599d61 into unjs:main Jan 19, 2025
5 checks passed
@iiio2 iiio2 deleted the docs/provide-clarity-on-package branch January 19, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants