-
Notifications
You must be signed in to change notification settings - Fork 5
feat!: implement with unjs template #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3 +/- ##
========================================
Coverage ? 100.00%
========================================
Files ? 1
Lines ? 20
Branches ? 7
========================================
Hits ? 20
Misses ? 0
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
/* eslint-disable-next-line unicorn/no-null */ | ||
let promise = fn(firstTask, null); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I pass undefined
instead?
"contributors": [ | ||
"Nozomu Ikuta <[email protected]>" | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course, only if you are fine.
📝 Applied unjs/template (until 070b86f) |
No related PRs.
I applied unjs/template to this repository.
serial
is nowPromise<unknown>
(as far as I research, there is no way to exactly infer type of the last result). Treating it asunknown
is for safety (cf.any
). I added "escape hatch" to its typing (i.e. second type argument), for cases where developer is sure what is return type of the function.Please close this PR with a message if it is not needed to "unjs-nize" the repository, or is there any other way I can contribute?