Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Units: add test using GNU extension regex pattern, i.e. \s, \w #3035

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hirooih
Copy link
Contributor

@hirooih hirooih commented May 22, 2021

dd177c3 just copy regex tests.
fc71cc9 uses GNU extension regex patterns.

Some changes are not equivalent with original to try more use of extensions.

@masatake
Copy link
Member

If you rebase your changes on the latest HEAD of the master branch, the failures on centos6 will be fixed.

@masatake
Copy link
Member

masatake commented Jun 1, 2021

These test cases can be used for testing p/pcre2 regex flags.

Some changes are not equivalent with original to try more use of extensions.
@codecov
Copy link

codecov bot commented Aug 12, 2021

Codecov Report

Merging #3035 (5938134) into master (41d7384) will not change coverage.
The diff coverage is n/a.

❗ Current head 5938134 differs from pull request most recent head 5ebfcc9. Consider uploading reports for the commit 5ebfcc9 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3035   +/-   ##
=======================================
  Coverage   87.35%   87.35%           
=======================================
  Files         200      200           
  Lines       47799    47799           
=======================================
  Hits        41756    41756           
  Misses       6043     6043           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41d7384...5ebfcc9. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants