Refactor request tests for service brokers

Instead of slicing the tests on user permissions, we are now slicing it on endpoints [#166631760] Co-authored-by: Derik Evangelista <[email protected]> Co-authored-by: Oleksii Fedorov <[email protected]> Co-authored-by: Winna Bridgewater <[email protected]>
univ0298 · Sep 3, 2019 · fcebddc · fcebddc
1 parent b50aecc
commit fcebddc
Show file tree

Hide file tree

Showing 7 changed files with 437 additions and 561 deletions.
diff --git a/Gemfile b/Gemfile
@@ -98,4 +98,5 @@ group :development do
   gem 'solargraph'
   gem 'spork', git: 'https://github.com/sporkrb/spork', ref: '224df49' # '~> 1.0rc'
   gem 'spring'
+  gem 'spring-commands-rspec'
 end
diff --git a/Gemfile.lock b/Gemfile.lock
@@ -412,6 +412,8 @@ GEM
       tilt (~> 2.0)
       yard (~> 0.9)
     spring (2.1.0)
+    spring-commands-rspec (1.0.4)
+      spring (>= 0.9.1)
     statsd-ruby (1.4.0)
     steno (1.3.4)
       fluent-logger
@@ -527,6 +529,7 @@ DEPENDENCIES
   solargraph
   spork!
   spring
+  spring-commands-rspec
   statsd-ruby (~> 1.4.0)
   steno
   talentbox-delayed_job_sequel (~> 4.3.0)

diff --git a/app/controllers/v3/service_brokers_controller.rb b/app/controllers/v3/service_brokers_controller.rb
@@ -59,6 +59,11 @@ def create
     unprocessable!(e.message)
   end
 
+  def delete
+    raise "real,ly unique mesage with stypos"
+    #render status: :ok, json: {}
+  end
+
   private
 
   def broker_not_found!

diff --git a/bin/rspec b/bin/rspec
@@ -0,0 +1,8 @@
+#!/usr/bin/env ruby
+begin
+  load File.expand_path('../spring', __FILE__)
+rescue LoadError => e
+  raise unless e.message.include?('spring')
+end
+require 'bundler/setup'
+load Gem.bin_path('rspec-core', 'rspec')
diff --git a/config/routes.rb b/config/routes.rb
@@ -164,6 +164,7 @@
   get '/service_brokers', to: 'service_brokers#index'
   get '/service_brokers/:guid', to: 'service_brokers#show'
   post '/service_brokers', to: 'service_brokers#create'
+  delete '/service_brokers/:guid', to: 'service_brokers#delete'
 
   # space_manifests
   post '/spaces/:guid/actions/apply_manifest', to: 'space_manifests#apply_manifest'