Remove vendor directory

- Relocate errors to their own top-level directory - This is legacy from when https://github.com/cloudfoundry-attic/errors was a submodule of CC - Vendor directory hides where error files live, especially since some editors don't index it Authored-by: Greg Cobb <[email protected]>
univ0298 · Jul 1, 2020 · 7188da1 · 7188da1
1 parent db63d9b
commit 7188da1
Show file tree

Hide file tree

Showing 10 changed files with 6 additions and 9 deletions.
diff --git a/.codeclimate.yml b/.codeclimate.yml
@@ -43,4 +43,4 @@ ratings:
   - "**.sh"
 exclude_paths:
 - docs/v3/node_modules/
-- vendor/
+- errors/
diff --git a/.rubocop.yml b/.rubocop.yml
@@ -7,7 +7,7 @@ require:
 AllCops:
   TargetRubyVersion: 2.5
   Exclude:
-    - vendor/**/*
+    - errors/**/*
     - lib/diego/bbs/models/**/*
     - lib/logcache/v2/**/*
 

diff --git a/.solargraph.yml b/.solargraph.yml
@@ -3,7 +3,7 @@ include:
 - "**/*.rb"
 exclude:
 - test/**/*
-- vendor/**/*
+- errors/**/*
 - ".bundle/**/*"
 require: []
 domains: []

diff --git a/vendor/errors/v1.yml → errors/v1.yml b/vendor/errors/v1.yml → errors/v1.yml
diff --git a/vendor/errors/v2.yml → errors/v2.yml b/vendor/errors/v2.yml → errors/v2.yml
diff --git a/vendor/errors/v3.yml → errors/v3.yml b/vendor/errors/v3.yml → errors/v3.yml
diff --git a/lib/cloud_controller/errors/details.rb b/lib/cloud_controller/errors/details.rb
@@ -22,7 +22,7 @@ def self.load_by_name(yaml_file_path)
     module V2
       class HardCodedDetails
         def self.yaml_file_path
-          File.join(File.expand_path('../../../vendor/errors', __dir__), 'v2.yml')
+          File.join(File.expand_path('../../../errors', __dir__), 'v2.yml')
         end
 
         HARD_CODED_DETAILS = CloudController::Errors::DetailsLoader.load_by_name(yaml_file_path)

diff --git a/lib/cloud_controller/errors/v3/details.rb b/lib/cloud_controller/errors/v3/details.rb
@@ -5,7 +5,7 @@ module Errors
     module V3
       class HardCodedDetails
         def self.yaml_file_path
-          File.join(File.expand_path('../../../../vendor/errors', __dir__), 'v3.yml')
+          File.join(File.expand_path('../../../../errors', __dir__), 'v3.yml')
         end
 
         HARD_CODED_DETAILS = DetailsLoader.load_by_name(yaml_file_path)

diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb
@@ -48,7 +48,7 @@
     require 'simplecov'
     SimpleCov.start do
       add_filter '/spec/'
-      add_filter '/vendor/'
+      add_filter '/errors/'
       add_filter '/docs/'
     end
   end

diff --git a/vendor/errors/README.md b/vendor/errors/README.md
-Original file line number
+Diff line change
@@ Expand Up / @@ -43,4 +43,4 @@ ratings: @@
       - "**.sh"
     exclude_paths:
     - docs/v3/node_modules/
-    - vendor/
+    - errors/