Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support python 3.12 and drop 3.9 #2066

Merged
merged 3 commits into from
Jun 26, 2024
Merged

Support python 3.12 and drop 3.9 #2066

merged 3 commits into from
Jun 26, 2024

Conversation

natestemen
Copy link
Member

@natestemen natestemen commented Oct 23, 2023 •
edited
Loading

Description

Add support for python 3.12, drop support for python 3.9.

Fixes #2395
Fixes #2215

@natestemen natestemen added the infrastructure For issues related to building, packaging, and continuous integration. label Oct 23, 2023
@natestemen natestemen mentioned this pull request Oct 23, 2023
Merged
@natestemen natestemen force-pushed the nts-python-312 branch 2 times, most recently from 05a006b to 6ccc50a Compare January 6, 2024 00:58
@natestemen
Copy link
Member Author

Looks like this is hung up on Qibo now. They are working on supporting 3.12 on their end: qiboteam/qibojit#170

@alecandido alecandido mentioned this pull request Feb 28, 2024
Merged
@natestemen natestemen self-assigned this Feb 29, 2024
@natestemen natestemen mentioned this pull request Mar 4, 2024
Closed
@natestemen natestemen added the monitor-for-external-solution Tracking issues caused by external packages label Mar 29, 2024
@cosenal cosenal marked this pull request as draft April 30, 2024 14:38
@cosenal cosenal mentioned this pull request Jun 24, 2024
Merged
@natestemen
Copy link
Member Author

After rebasing and setting up the mitiq env with python 3.12, make install and make test were able to run with the current cirq-core restrictions (cirq-core 1.3.0 installed). We (@cosenal and I) previously thought that we would have to bump cirq-core in order for our tests to pass and hence merge the changes in #2390 into this PR, but this demonstrated not to be the case.

Hence, we are moving forward with "just" dropping python 3.9 and adding tested support for 3.12.

@codecov Codecov
Copy link

codecov bot commented Jun 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.32%. Comparing base (20732a0) to head (36b01c7).
Report is 44 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2066   +/-   ##
=======================================
  Coverage   98.32%   98.32%           
=======================================
  Files          87       87           
  Lines        4048     4048           
=======================================
  Hits         3980     3980           
  Misses         68       68

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@natestemen natestemen marked this pull request as ready for review June 26, 2024 18:11
@natestemen natestemen requested a review from cosenal June 26, 2024 18:11
cosenal
cosenal approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@cosenal cosenal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢🚢
When you merge it, please make sure the main commit message mentions dropping 3.9

@natestemen natestemen changed the title Support python 3.12 Support python 3.12 and drop 3.9 Jun 26, 2024
@natestemen natestemen merged commit 80cf118 into main Jun 26, 2024
31 checks passed
@natestemen natestemen deleted the nts-python-312 branch June 26, 2024 19:16
@natestemen
Copy link
Member Author

make sure the main commit message mentions dropping 3.9

good idea. changed PR title to more accurately reflect that (and subsequently the merge commit).

cosenal pushed a commit that referenced this pull request Jun 26, 2024
@natestemen @cosenal
Support python 3.12 and drop 3.9 (#2066)
adf5f96 
* add python 3.12 to CI

* use python 3.12 on RTD

* remove python 3.9 support/tests
@natestemen natestemen mentioned this pull request Jun 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cosenal cosenal cosenal approved these changes

Assignees

@natestemen natestemen

Labels
infrastructure For issues related to building, packaging, and continuous integration. monitor-for-external-solution Tracking issues caused by external packages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Python 3.12 support Drop Python 3.9 support
2 participants
@natestemen @cosenal