Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upper cap sklearn to <1.6.0 due to xgboost not supporting it #2618

Merged
merged 1 commit into from
Dec 14, 2024

Conversation

dennisbader
Copy link
Collaborator

@dennisbader dennisbader commented Dec 14, 2024

Checklist before merging this PR:

  • Mentioned all issues that this PR fixes or addresses.
  • Summarized the updates of this PR under Summary.
  • Added an entry under Unreleased in the Changelog. (not required)

Summary

  • scikit-learn released version 1.6.0 and xgboost does not support it yet
  • fixes failing unit test checks by upper-capping sklearn to 1.6.0
  • we'll relax this once xgboost has added support

Copy link

codecov bot commented Dec 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.10%. Comparing base (51b026b) to head (10e8e57).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2618      +/-   ##
==========================================
- Coverage   94.15%   94.10%   -0.06%     
==========================================
  Files         139      139              
  Lines       14992    14992              
==========================================
- Hits        14116    14108       -8     
- Misses        876      884       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dennisbader dennisbader merged commit 71a1902 into master Dec 14, 2024
9 checks passed
@dennisbader dennisbader deleted the dep/sklearn_uc_160 branch December 14, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant