Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ruff to 0.7.2 and target python to 3.9 #2589

Merged
merged 14 commits into from
Nov 11, 2024
Merged

Conversation

madtoinou
Copy link
Collaborator

@madtoinou madtoinou commented Nov 8, 2024

Checklist before merging this PR:

  • Mentioned all issues that this PR fixes or addresses.
  • Summarized the updates of this PR under Summary.
  • Added an entry under Unreleased in the Changelog.

Fixes #2547, superseed #2548

Summary

  • Update ruff to 0.7.2 (latest release)
  • As python3.8 is not supported since bump minimum python version from 3.8 to 3.9 #2586, also update the linting target language to python 3.9; this change has a considerable impact on the typing import and declarations

Additional information

This PR commit must be added to the git-blame-ignore

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@madtoinou madtoinou mentioned this pull request Nov 8, 2024
3 tasks
Copy link
Collaborator

@dennisbader dennisbader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @madtoinou 🚀

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.09%. Comparing base (dec18b2) to head (3fbcc24).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2589      +/-   ##
==========================================
+ Coverage   93.93%   94.09%   +0.15%     
==========================================
  Files         139      139              
  Lines       14888    14882       -6     
==========================================
+ Hits        13985    14003      +18     
+ Misses        903      879      -24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@madtoinou madtoinou merged commit 18e2e3f into master Nov 11, 2024
9 checks passed
@madtoinou madtoinou deleted the fix/update_ruff branch November 11, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update ruff to v6.8
3 participants