Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replacing deprecated "squared": False from mean_squared_error #2554

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

quant12345
Copy link
Contributor

@quant12345 quant12345 commented Oct 4, 2024

Checklist before merging this PR:

  • Mentioned all issues that this PR fixes or addresses.
  • Summarized the updates of this PR under Summary.
  • Added an entry under Unreleased in the Changelog.

Removes warning:FutureWarning: 'squared' is deprecated in version 1.4 and will be removed in 1.6. To calculate the root mean squared error, use the function'root_mean_squared_error'.

Discussion #2551

I didn't do versioning to choose mean_squared_error {"squared": False}or root_mean_squared_error, depending on which version of scikit-learn.

As far as I understand, you are stopping support for Python 3.8.
The next version of scikit-learn after 1.3.2 will 1.4.0 (where root_mean_squared_error appeared) and version 1.4.0 supports Python versions starting from 3.9.

That is, tests will fail on Python 3.8, since for scikit-learn >= 1.4.0, Python >= 3.9 is needed.
But you can just take your time with this PR)

Summary

Replacing deprecated "squared": False from mean_squared_error, instead it is used root_mean_squared_error.

Other Information

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.87%. Comparing base (36d041c) to head (a8ea376).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2554      +/-   ##
==========================================
- Coverage   93.93%   93.87%   -0.07%     
==========================================
  Files         139      139              
  Lines       14888    14888              
==========================================
- Hits        13985    13976       -9     
- Misses        903      912       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@quant12345
Copy link
Contributor Author

In Actions 01-multi-time-series-and-covariates.ipynb it gives: DatasetLoadingException: Could not download the dataset. Reason:BadZipFile('File is not a zip file').

Probably some failure in loading?

@quant12345 quant12345 closed this Oct 5, 2024
@quant12345 quant12345 reopened this Oct 5, 2024
Copy link
Collaborator

@dennisbader dennisbader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @quant12345. We now bumped python 3.8 support, so this is good to go 🚀

@dennisbader dennisbader merged commit a674ed2 into unit8co:master Nov 7, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants