Fewer dependencies for the container image #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This got me thinking... Should we name and/or tag the artifacts better? Naming them something like |
- The entrypoint in the container image will create the CITEXT extension in the database if needed. - The container image is built with default mregsite and logs directories, so it can run without these being mounted into it. - A docker-compose.yml file is added to the repo. - The section about Docker in the README file is updated.
When using entrypoint-test.sh, the CITEXT extension ended up being created in the regular mreg database, when it needs to be created in the template1 database so it propagates to the temporary database created by manage.py test.
oyvindhagberg
force-pushed
the
self-reliant-container-2023w13
branch
from
775187c
to
b73ed70
Compare
Good idea, let's do that, but not in this pull request. I created an issue |
terjekv
approved these changes
Mar 31, 2023
Also, add a few words to README.md about dependencies for PostgreSQL
terjekv
approved these changes
Mar 31, 2023
terjekv
approved these changes
Apr 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
The container-image.yml workflow is modified to trigger on pushes to all branches, but only push the built image to ghcr.io if the branch is master. This way, we get to test that workflow on new code before merging into master.Done in 749d096