-
Notifications
You must be signed in to change notification settings - Fork 3.2k
feat(tools): rustfmt sort tool #4614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@marvelshan is attempting to deploy a commit to the unionbuild Team on Vercel. A member of the Team first needs to authorize it. |
@benluelo I tried running the CI for it but ran into a couple of issues that I’m currently stuck on, and I was wondering if you might have any suggestions. Here are the main errors I encountered:
Would you happen to know what might be causing the |
@marvelshan are you using the rust version from the repo? this should not be an issue as we have not yet bumped to the 2024 edition. you should use |
fc1477c
to
0911553
Compare
0911553
to
67c5724
Compare
@benluelo I'm using the Rust version provided by the repo via (nix:union-devShell-env) zaki@ubuntu:~/union$ echo $IN_NIX_SHELL
impure
(nix:union-devShell-env) zaki@ubuntu:~/union$ rustc --version
rustc 1.87.0-nightly (3f5502370 2025-03-27)
(nix:union-devShell-env) zaki@ubuntu:~/union$ cargo --version
cargo 1.87.0-nightly (a6c604d1b 2025-03-26) The edition field in [workspace.package]
edition = "2021" However, when I run
This happens in multiple files, mostly in code using Also, I noticed
Could this be causing |
you've updated the flake.lock again. revert changes to that file, and don't update it. |
Thank you for your reminder, and I apologize for any unnecessary changes caused by the changes to flake.lock. I have reviewed the Nix documentation regarding flake.lock and have reverted the file to its original state. Please let me know if there is anything else I should adjust. |
88686c6
to
46f8fd2
Compare
fb26b79
to
15416ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for doing the monke work here, pushed a few more small changes and regenerated the protos
Which issue does this PR close?
closes #4360
Why
This change introduces a deterministic Rust file sorting tool (rustfmt-sort) into the proto code generation pipeline. The motivation is to ensure that all generated Rust files have a stable, alphabetically sorted item order, which:
Additionally, due to limitations in the proto generator, a manual patch for the timestamp field in CanonicalVote is still required after generation.
Implementation details
Modules Affected