Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Umi restructure #123

Merged
merged 14 commits into from
Jan 29, 2024
Merged

Umi restructure #123

merged 14 commits into from
Jan 29, 2024

Conversation

SeppFS
Copy link
Contributor

@SeppFS SeppFS commented Dec 18, 2023 •
edited
Loading

List of issues that this PR closes

#121

Relevant decisions you made in this PR

  • Error Handling Implementation for .umi parsing
  • Using Serde Conditionals to prevent parsing of Default Values
  • Store all general Attributes to 'Properties' Column

@SeppFS SeppFS linked an issue Dec 18, 2023 that may be closed by this pull request
[REQ] Improve .umi Format #121
Closed
7 tasks
@SeppFS SeppFS self-assigned this Jan 12, 2024
mhatzl
mhatzl requested changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@mhatzl mhatzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am really happy with the change to the properties column and serde serialization. 👍

Requested changes are mostly cosmetic.
Just reading back the BulletListEntry content seems incorrect.

cli/src/compiler.rs Show resolved Hide resolved
cli/tests/umi.rs Outdated Show resolved Hide resolved
cli/tests/umi.rs Outdated Show resolved Hide resolved
cli/tests/umi.rs Outdated Show resolved Hide resolved
cli/tests/umi.rs Outdated Show resolved Hide resolved
render/src/umi/render.rs Show resolved Hide resolved
render/src/umi/render.rs Show resolved Hide resolved
render/src/umi/render.rs Show resolved Hide resolved
render/src/umi/render.rs Show resolved Hide resolved
render/src/umi/render.rs Show resolved Hide resolved
mhatzl
mhatzl requested changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@mhatzl mhatzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your fast response.

I made one remark about using consts instead of magic numbers for column indices, because there are now "default" columns and intended columns for content and attributes.

render/src/umi/mod.rs Show resolved Hide resolved
render/src/umi/render.rs Show resolved Hide resolved
render/src/umi/mod.rs Outdated Show resolved Hide resolved
@SeppFS SeppFS marked this pull request as ready for review January 24, 2024 13:05
@mhatzl mhatzl mentioned this pull request Jan 29, 2024
Merged
mhatzl
mhatzl reviewed Jan 29, 2024
View reviewed changes
render/src/umi/mod.rs Outdated Show resolved Hide resolved
mhatzl
mhatzl approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@mhatzl mhatzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx for the quick change :)

@SeppFS SeppFS merged commit 7a46853 into main Jan 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhatzl mhatzl mhatzl approved these changes

Assignees

@SeppFS SeppFS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[REQ] Improve .umi Format
2 participants
@SeppFS @mhatzl