fix: change to Apache 2.0 license and general cleanup #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfejzic
previously approved these changes
Oct 2, 2023
Co-authored-by: Nadir Fejzić <[email protected]>
Co-authored-by: Nadir Fejzić <[email protected]>
Co-authored-by: Nadir Fejzić <[email protected]>
|
Thanks for your fast feedback. |
nfejzic
approved these changes
Oct 4, 2023
nfejzic
reviewed
Oct 4, 2023
Comment on lines
-13
to
-20
| build: | ||
| name: Run Build | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - name: Build | ||
| run: cargo build --verbose |
There was a problem hiding this comment.
I don't think we should remove the Build step completely. Also, seems like the PR workflow status is stuck because it is missing 🤣. So yeah...
But either way, I think we should keep it.
There was a problem hiding this comment.
clippy is already building the crate, and cargo test also builds the crate. Having build as additional job just increases the workflow duration without giving us any additional information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of issues that this PR closes
closes #108
Relevant decisions you made in this PR
Switched to Apache 2.0, because it is more precise than MIT.
Removed the build-step, because clippy already builds everything.
Removed issue templates, because templates should be taken from the
.githubrepo in the Unimarkup organization.