This repository has been archived by the owner on Jul 17, 2023. It is now read-only.
Fix arm64 errors #78
Closed
Fix arm64 errors #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until now, aarch64 gcc was trying to use the x86 assembler, generating a build error. This commit adds the missing `aarch64-linux-gnu` directory to the kraft container, solving this issue.
`kraft run` is always trying to enable hardware acceleration, even when the host has an achitecture different from the emulated one. This commit solves the problem, taking into account the host architecture when generating the qemu command.
Before this commit, the gcc container image couldn't be built on arm or x86_64, generating a `file not found error`. Replace `aarch64-linux-gnu` in Dockerfile.gcc with the GCC_PREFIX that is architecture specific. This way, the problematic folder will always be found. This should also allow `kraft build` to cross-compile images on any architecture.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR comes to solve issue #57. There are two problems with kraft on ARM64, solved by two different commits:
kraft buildusesaarch64-linux-gnu-gcc, which in turn calls the x86_64 assembler, resulting in a build error. At first, I was thinking about replacing the current arm64 toolchain with the linaro one (as mentioned in a previous comment). Finally, I managed to solve this by adding a missing directory (aarch64-linux-gnu) to the final kraft container. This way, we don't need to add linaro anymore.In order for this to work fine, I think we should also update the
unikraft/gcc:9.2.0-arm64-stagingimage from docker hub[1].kraft runis always trying to enable hardware acceleration, even if the host architecture is different from the emulated one. This generates errors when trying to emulate ARM64 images on x86 hosts. The problem can be easily solved by checking the architecture inkvm.pyand generating the right qemu command.[1]https://hub.docker.com/layers/unikraft/gcc/9.2.0-arm64/images/sha256-3fd1ce6b6f7acb9e259212bf922b8b2090f10cf0e93621f94f04c51a92a5835e?context=explore
Signed-off-by: Răzvan Vîrtan [email protected]