Update version: 1.2.12 -> 1.2.13 #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sabanic-P
changed the title
Closed
razvand
added
enhancement
Closed
razvand
reviewed
Oct 23, 2022
There was a problem hiding this comment.
Hi, @Sabanic-P . Thanks for this. Please improve your commit message. Present tense: "Update library version to 1.2.13". Please also mention in the extended commit message the test used.
Follow this link for commit messages, also mentioned in the Submitting Changes page.
|
@Sabanic-P , 20 points awarded. 20 points more for solving the comments for the PR to be merged. |
Sabanic-P
force-pushed
the
changeto.13
branch
from
635f64a to
d7469b1
Compare
Test used: https://github.com/madler/zlib/blob/master/test/example.c Signed-off-by: Patrick Sabanic <[email protected]>
Sabanic-P
force-pushed
the
changeto.13
branch
from
d7469b1 to
27d308a
Compare
razvand
approved these changes
Oct 23, 2022
There was a problem hiding this comment.
Thanks, @Sabanic-P
Reviewed-by: Razvan Deaconescu [email protected]
Approved-by: Razvan Deaconescu [email protected]
|
@Sabanic-P , 20 more hackathon points added for the approval. |
|
Hi, can this please be merged because the 1.2.12 version is still causing issues when building. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version only had minor code changes.
A simple Test program runs without any problem.
Signed-off-by: Patrick Sabanic [email protected]