Skip to content

Commit

Permalink
fix(governctl): Add unknown commits as exception
Browse files Browse the repository at this point in the history
Because of how governctl structures temp repos it makes it
impossible for checkpatch to look behind and check if a
commit in a body is referenced correctly. This is fine.
It can be checked by hand with the script and can also
be observed in GitHub if the sha mentioned is invalid.

Signed-off-by: Cezar Craciunoiu <[email protected]>
  • Loading branch information
craciunoiuc committed Oct 2, 2024
1 parent 7dbeca9 commit 0e9def0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion cmd/governctl/pr/check/patch.go
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ func NewPatch() *cobra.Command {
}

func (opts *Patch) Run(ctx context.Context, args []string) error {
var extraIgnores []string
var extraIgnores = []string{"UNKNOWN_COMMIT_ID"}

ghOrg, ghRepo, ghPrId, err := cmdutils.ParseOrgRepoAndPullRequestArgs(args)
if err != nil {
Expand Down

0 comments on commit 0e9def0

Please sign in to comment.