Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add p7zip #80

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add p7zip #80

wants to merge 2 commits into from

Conversation

sinamhdv
Copy link
Contributor

No description provided.

added root directory, binary, and libraries for nasm to the dynamic-apps that can be run in bincompat mode.

Signed-off-by: Sina Mahdavi <[email protected]>
Added p7zip file compression utility to dynamic apps. This includes the root directory, README.md, libraries, binaries, and sample files.

Signed-off-by: Sina Mahdavi <[email protected]>
@StefanJum StefanJum self-assigned this Sep 25, 2023
@StefanJum StefanJum self-requested a review September 25, 2023 14:40
Copy link
Member

@StefanJum StefanJum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sinamhdv remove the nasm related commit, since it's covered in #75
Also reword the commit message to Add p7zip dynamic application and wrap the commit description lines to ~70 characters.

- `7z.so`, `7za`, `7zCon.sfx`, `7zr`: different code modules for p7zip that will be used by 7z binary to perform different operations.

## Extracting Dynamic Libraries

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add wording here.


## Running on Linux

This will create a new archive called `archive.zip` and add the file `README.md` to it.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This will create a new archive called `archive.zip` and add the file `README.md` to it.
Create a new archive called `archive.zip` and add the file `README.md` to it:

7z a archive.zip README.md
```

This will extract the archive:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This will extract the archive:
Extract the archive created above:


## Running on Unikraft

This will create a new archive called `archive.zip` and add the file `README.md` to it.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This will create a new archive called `archive.zip` and add the file `README.md` to it.
Create a new archive called `archive.zip` and add the file `README.md` to it:

./run.sh -r ../dynamic-apps/p7zip /7z a archive.zip README.md
```

This will extract an archive file called `archive.zip`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This will extract an archive file called `archive.zip`.
Extract an archive file called `archive.zip`.

```

## Running on Unikraft

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a line on using the run.sh script from the run-app-elfloader repository (see an example here).

```console
./run.sh -r ../dynamic-apps/p7zip /7z a archive.zip README.md
```

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Give an output sample of the command above.

```console
./run.sh -r ../dynamic-apps/p7zip /7z x archive.zip
```

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Give an output sample of the command above.

./run.sh -r ../dynamic-apps/p7zip /7z x archive.zip
```

We can use this command to check that everything worked properly:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
We can use this command to check that everything worked properly:
To check that everything worked properly, use:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants