Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Upgrade make properclean to make distclean #475

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ThestralWarrior
Copy link

@ThestralWarrior ThestralWarrior commented Jan 18, 2025

Using make distclean avoids issues created from residual build artifacts.
After building for x86_64 architecture, the user follows the guide and uses make properclean which only gets rid of build and not the config which leads to the following error when building for arm64 -

> /home/ashirvad/workdir/helloworld/workdir/unikraft/plat/common/include/x86/irq.h: In function ‘irqs_disabled’:
> /home/ashirvad/workdir/helloworld/workdir/unikraft/plat/common/include/x86/irq.h:61:28: error: ‘X86_EFLAGS_IF’ undeclared (first use in this function)
>    61 |                 x = (__f & X86_EFLAGS_IF) ? 1 : 0; \
>       |                            ^~~~~~~~~~~~~
> /home/ashirvad/workdir/helloworld/workdir/unikraft/plat/common/include/x86/irq.h:82:9: note: in expansion of macro ‘__save_flags’
>    82 |         __save_flags(flag);
>       |         ^~~~~~~~~~~~
> /home/ashirvad/workdir/helloworld/workdir/unikraft/plat/common/include/x86/irq.h:61:28: note: each undeclared identifier is reported only once for each function it appears in
>    61 |                 x = (__f & X86_EFLAGS_IF) ? 1 : 0; \
>       |                            ^~~~~~~~~~~~~
> /home/ashirvad/workdir/helloworld/workdir/unikraft/plat/common/include/x86/irq.h:82:9: note: in expansion of macro ‘__save_flags’
>    82 |         __save_flags(flag);
>       |         ^~~~~~~~~~~~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant