blog: Add GSoC'24 UEFI GOP, Part II post #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanJum
requested changes
Jul 12, 2024
|
|
||
| The widely available and standardized [UEFI Graphics Output Protocol](https://uefi.org/specs/UEFI/2.10/12_Protocols_Console_Support.html#efi-graphics-output-protocol) (GOP) interface is an excellent alternative to VGA or serial port consoles for printing logs to the screen. | ||
|
|
||
| This project aims to implement a UEFI GOP based console. For more information, check out [Part I](https://unikraft.org/blog/2024-06-18-gsoc-uefi-gop) of this series. |
There was a problem hiding this comment.
Suggested change
| This project aims to implement a UEFI GOP based console. For more information, check out [Part I](https://unikraft.org/blog/2024-06-18-gsoc-uefi-gop) of this series. | |
| This project aims to implement a UEFI GOP based console. | |
| For more information, check out [Part I](https://unikraft.org/blog/2024-06-18-gsoc-uefi-gop) of this series. |
Use one line per sentence and one sentence per line
|
|
||
| This project aims to implement a UEFI GOP based console. For more information, check out [Part I](https://unikraft.org/blog/2024-06-18-gsoc-uefi-gop) of this series. | ||
|
|
||
| ## Progress |
There was a problem hiding this comment.
Suggested change
| ## Progress | |
| ## Progress | |
| This project aims to implement a UEFI GOP based console. For more information, check out [Part I](https://unikraft.org/blog/2024-06-18-gsoc-uefi-gop) of this series. | ||
|
|
||
| ## Progress | ||
| - Using a placeholder [font](https://github.com/dhepper/font8x8), it is now possible to print null-terminated strings to the screens |
There was a problem hiding this comment.
Suggested change
| - Using a placeholder [font](https://github.com/dhepper/font8x8), it is now possible to print null-terminated strings to the screens | |
| - Using a placeholder [font](https://github.com/dhepper/font8x8), it is now possible to print null-terminated strings to the screens. | |
| src="/images/uefi-gop-after-scrolling.png" | ||
| /> | ||
|
|
||
| Right now, scrolling moves all the framebuffer data in place. Reads and writes in framebuffer memory are slower because the video adapter driver actually syncs the framebuffer with the screen. This needs to be optimized! |
There was a problem hiding this comment.
Suggested change
| Right now, scrolling moves all the framebuffer data in place. Reads and writes in framebuffer memory are slower because the video adapter driver actually syncs the framebuffer with the screen. This needs to be optimized! | |
| Right now, scrolling moves all the framebuffer data in place. | |
| Reads and writes in framebuffer memory are slower because the video adapter driver actually syncs the framebuffer with the screen. | |
| This needs to be optimized! |
Use one line per sentence and one sentence per line
|
|
||
| Right now, scrolling moves all the framebuffer data in place. Reads and writes in framebuffer memory are slower because the video adapter driver actually syncs the framebuffer with the screen. This needs to be optimized! | ||
|
|
||
| ## Next Steps |
There was a problem hiding this comment.
Suggested change
| ## Next Steps | |
| ## Next Steps | |
| - Optimize scrolling (by maintaining an additional buffer(?)) | ||
| - Look into [this PR](https://github.com/unikraft/unikraft/pull/1464), which adds a generic console interface. | ||
|
|
||
| ## Acknowledgement |
There was a problem hiding this comment.
Suggested change
| ## Acknowledgement | |
| ## Acknowledgement | |
|
@mogasergiu can you also take a look content-wise? |
mogasergiu
suggested changes
Jul 12, 2024
| src="/images/uefi-gop-after-scrolling.png" | ||
| /> | ||
|
|
||
| Right now, scrolling moves all the framebuffer data in place. Reads and writes in framebuffer memory are slower because the video adapter driver actually syncs the framebuffer with the screen. This needs to be optimized! |
There was a problem hiding this comment.
Suggested change
| Right now, scrolling moves all the framebuffer data in place. Reads and writes in framebuffer memory are slower because the video adapter driver actually syncs the framebuffer with the screen. This needs to be optimized! | |
| Right now, scrolling moves all the framebuffer data in place. Reads and writes in framebuffer memory are slower because the video adapter actually syncs the framebuffer with the screen. This needs to be optimized! |
|
|
||
| ## Next Steps | ||
| - Finalize a font! | ||
| - Optimize scrolling (by maintaining an additional buffer(?)) |
There was a problem hiding this comment.
Suggested change
| - Optimize scrolling (by maintaining an additional buffer(?)) | |
| - Optimize scrolling (by maintaining an additional buffer) |
Yes we should use double buffering :). Side note, I noticed that in your PR you memcpy for scrolling (unless I misread that). Try to replace that with a memmove. :)
This is the second post that outlines the progress on the UEFI GOP GSoC project, particulary from week four to six. Signed-off-by: procub3r <[email protected]>
|
@StefanJum @mogasergiu Made all the corrections! |
mogasergiu
approved these changes
Jul 12, 2024
StefanJum
approved these changes
Jul 12, 2024
There was a problem hiding this comment.
Reviewed-by: Stefan Jumarea [email protected]
Approved-by: Stefan Jumarea [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second post that outlines the progress on the UEFI GOP GSoC project, particulary from week four to six.