Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Nginx Version And Network Syntax #373

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

unsuman
Copy link
Contributor

@unsuman unsuman commented Feb 29, 2024

Changes are made in Guide-Using the Application Catalog:

  • Updated the Nginx version in the kraft run command from unikraft.org/nginx to unikraft.org/nginx:1.15.
  • Replaced a deprecated network command with its updated equivalent.

@razvand razvand self-requested a review March 2, 2024 12:39
@razvand razvand self-assigned this Mar 2, 2024
Copy link
Contributor

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @unsuman.

Thanks for the PR. Please use the commit message as guides: Update Nginx version and network syntax.

Please also use your complete name (Firstname Lastname) as part of both the author name and the Signed-off-by name.

Copy link
Member

@StefanJum StefanJum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@unsuman do not use merge commits. To rebase your work on the main branch use git rebase main, not git merge.

@unsuman unsuman force-pushed the unsuman/fix-nginx-version branch from cc84f40 to 54ca8d7 Compare March 2, 2024 16:27
@unsuman
Copy link
Contributor Author

unsuman commented Mar 2, 2024

Is it ok now?

@razvand razvand requested review from razvand and StefanJum March 2, 2024 19:22
Copy link
Contributor

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @unsuman . Please use present tense: Update instead of Updated. Also use and instead of And in the message.

@unsuman unsuman force-pushed the unsuman/fix-nginx-version branch from 54ca8d7 to 248c7cc Compare March 13, 2024 10:35
@razvand razvand self-requested a review March 13, 2024 10:48
@razvand
Copy link
Contributor

razvand commented Mar 13, 2024

@unsuman , please use the same name for the commit author and the signed-off-by item. You can amend your commit:

[email protected] GIT_COMMITTER_NAME="Ansuman Sahoo" [email protected] GIT_AUTHOR_NAME="Ansuman Sahoo" git commit --amend --reset-author

@unsuman unsuman force-pushed the unsuman/fix-nginx-version branch from 248c7cc to 61131cc Compare March 13, 2024 10:54
content/guides/using-the-app-catalog.mdx Outdated Show resolved Hide resolved
@unsuman unsuman force-pushed the unsuman/fix-nginx-version branch 2 times, most recently from eb04bbc to d942528 Compare March 13, 2024 11:05
@razvand
Copy link
Contributor

razvand commented Mar 13, 2024

@unsuman , remove the extra Author: line from the commit message.

@unsuman unsuman force-pushed the unsuman/fix-nginx-version branch from d942528 to 401f3b4 Compare March 13, 2024 11:31
@unsuman
Copy link
Contributor Author

unsuman commented Mar 13, 2024

@unsuman , remove the extra Author: line from the commit message.

Done.

Copy link
Contributor

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-by: Razvan Deaconescu [email protected]
Approved-by: Razvan Deaconescu [email protected]

@razvand razvand merged commit 27baee1 into unikraft:main Mar 13, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants