-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Nginx Version And Network Syntax #373
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @unsuman.
Thanks for the PR. Please use the commit message as guides: Update Nginx version and network syntax
.
Please also use your complete name (Firstname Lastname
) as part of both the author name and the Signed-off-by
name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@unsuman do not use merge commits. To rebase your work on the main branch use git rebase main
, not git merge
.
cc84f40
to
54ca8d7
Compare
Is it ok now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @unsuman . Please use present tense: Update
instead of Updated
. Also use and
instead of And
in the message.
54ca8d7
to
248c7cc
Compare
@unsuman , please use the same name for the commit author and the signed-off-by item. You can amend your commit: [email protected] GIT_COMMITTER_NAME="Ansuman Sahoo" [email protected] GIT_AUTHOR_NAME="Ansuman Sahoo" git commit --amend --reset-author |
248c7cc
to
61131cc
Compare
eb04bbc
to
d942528
Compare
@unsuman , remove the extra |
Signed-off-by: Ansuman Sahoo <[email protected]>
d942528
to
401f3b4
Compare
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed-by: Razvan Deaconescu [email protected]
Approved-by: Razvan Deaconescu [email protected]
Changes are made in Guide-Using the Application Catalog:
kraft run
command fromunikraft.org/nginx
tounikraft.org/nginx:1.15
.