Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing some typos in the documentation #369

Merged
merged 5 commits into from
Mar 19, 2024
Merged

Conversation

fabbing
Copy link
Contributor

@fabbing fabbing commented Jan 23, 2024

I've been learning about Unikraft and have started by going through the documentation, which I've found really interesting and instructive! Thanks for the effort you've put into it.
I found a few typos or corrections that could be made, so here's a little PR to improve it a bit. :)

@razvand razvand self-requested a review March 2, 2024 12:36
@razvand razvand self-assigned this Mar 2, 2024
Copy link
Contributor

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @fabbing , thanks so much for your contribution.

Please sign off your commits. Maybe you would also use a single e-mail address, right now you're using both [email protected] and [email protected].

Please also prefix your commit message with the "area" of change: docs/cli, docs/concepts, docs/internals.

@fabbing
Copy link
Contributor Author

fabbing commented Mar 7, 2024

Thanks for pointing this out @razvand! I think the commits now look as expected.

@razvand razvand self-requested a review March 12, 2024 14:43
@razvand
Copy link
Contributor

razvand commented Mar 12, 2024

Thanks for pointing this out @razvand! I think the commits now look as expected.

Hi, @fabbing , sorry for the late reply.

Yes, looks good. Please sign off your commits, as told in the submission checklist. That is, add the line to each commit message:

Signed-off-by: Fabrice Buoro <[email protected]>

Also use your full name in the commit author. You can use a command such as:

[email protected] GIT_COMMITTER_NAME="Fabrice Buoro" [email protected] GIT_AUTHOR_NAME="Fabrice Buoro" git commit --amend --reset-author

@razvand razvand closed this Mar 12, 2024
@razvand razvand reopened this Mar 12, 2024
@razvand
Copy link
Contributor

razvand commented Mar 14, 2024

Also, @fabbing , take care of the merge conflicts.

fabbing added 5 commits March 15, 2024 18:32
Redundant quoting in build-system.mdx.

Signed-off-by: Fabrice Buoro <[email protected]>
This content in architecture.mdx is also in build-process.mdx.

Signed-off-by: Fabrice Buoro <[email protected]>
@fabbing
Copy link
Contributor Author

fabbing commented Mar 15, 2024

Ironically, I must have missed this part of the documentation, sorry.

Rebased, fixed commit messages that were too long, and signed the commits properly.

Copy link
Member

@StefanJum StefanJum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, thanks.
Reviewed-by: Stefan Jumarea [email protected]
Approved-by: Stefan Jumarea [email protected]

@StefanJum StefanJum merged commit 5e1b03a into unikraft:main Mar 19, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants