-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing some typos in the documentation #369
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @fabbing , thanks so much for your contribution.
Please sign off your commits. Maybe you would also use a single e-mail address, right now you're using both [email protected]
and [email protected]
.
Please also prefix your commit message with the "area" of change: docs/cli
, docs/concepts
, docs/internals
.
Thanks for pointing this out @razvand! I think the commits now look as expected. |
Hi, @fabbing , sorry for the late reply. Yes, looks good. Please sign off your commits, as told in the submission checklist. That is, add the line to each commit message:
Also use your full name in the commit author. You can use a command such as: [email protected] GIT_COMMITTER_NAME="Fabrice Buoro" [email protected] GIT_AUTHOR_NAME="Fabrice Buoro" git commit --amend --reset-author |
Also, @fabbing , take care of the merge conflicts. |
Signed-off-by: Fabrice Buoro <[email protected]>
Redundant quoting in build-system.mdx. Signed-off-by: Fabrice Buoro <[email protected]>
This content in architecture.mdx is also in build-process.mdx. Signed-off-by: Fabrice Buoro <[email protected]>
Signed-off-by: Fabrice Buoro <[email protected]>
Signed-off-by: Fabrice Buoro <[email protected]>
Ironically, I must have missed this part of the documentation, sorry. Rebased, fixed commit messages that were too long, and signed the commits properly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good, thanks.
Reviewed-by: Stefan Jumarea [email protected]
Approved-by: Stefan Jumarea [email protected]
I've been learning about Unikraft and have started by going through the documentation, which I've found really interesting and instructive! Thanks for the effort you've put into it.
I found a few typos or corrections that could be made, so here's a little PR to improve it a bit. :)