Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configs/internals: Remove reference to coding conventions #334

Merged

Conversation

StefanJum
Copy link
Member

The cofing conventions are under contributing/, not under internals/. This would result in a 404 error.

The cofing conventions are under `contributing/`, not under
`internals/`. This would result in a 404 error.

Signed-off-by: Stefan Jumarea <[email protected]>
Copy link
Contributor

@mariasfiraiala mariasfiraiala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, thanks!

Reviewed-by: Maria Sfiraiala [email protected]
Approved-by: Maria Sfiraiala [email protected]

@StefanJum StefanJum assigned mariasfiraiala and unassigned razvand Oct 6, 2023
@StefanJum StefanJum merged commit ad11458 into unikraft:main Oct 6, 2023
@StefanJum StefanJum deleted the StefanJum/remove-internals-codingc branch October 6, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants