fix(library): Update Nginx config #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Nginx config file to not use `/dev/stdout`, since Unikraft does not properly support it yet. GitHub-Closes: unikraft#31 Signed-off-by: Stefan Jumarea <[email protected]>
StefanJum
force-pushed
the
StefanJum/fin-nginx-config
branch
from
59235fe to
b2552ae
Compare
|
Hi, this is untrue: https://github.com/unikraft/unikraft/blob/staging/lib/devfs/stdout.c#L94-L104 I believe the issue you are trying to tackle is related in fact with a bug or config mismatch with vfstab and devfs. |
Agree, but the underlying issue might take some time to get fixed, so I would add this as a quick fix. Up to you though. LE: The actual issue was not that hard to find, this pr should fix it, so after that is done we can close this pr. |
|
Closing as unikraft#1231 is now merged and the image boots and operates as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Nginx config file to not use
/dev/stdout, since Unikraft does not properly support it yet.