-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(examples): Introduce Python 3 HTTP Server #11
base: main
Are you sure you want to change the base?
Conversation
ee8d4f4
to
2d84a72
Compare
e47c163
to
8a4d5df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good besides the one comment.
``` | ||
|
||
It will print "Hello, World!". | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the extra line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good.
Approved-by: Alexander Jung <[email protected]>
Introduce Python script to generate run scripts for bincompat use cases. Add base `docker.Makefile` to be included for Docker-based builds. Script is to be run from corresponding bincompat app directory in examples: ``` ../../utils/bincompat/generate.py ``` Application directories must define the `config.yaml` file with required variables: `networking`, `accel`, `memory` etc. Running it generates the following files: * `kraft-run*.sh`: script to run with KraftKit * `run-qemu*.sh`: script to run with QEMU * `run-fc*.sh`: script to run with Firecracker * `fc*.json`: Firecracker configuration files Signed-off-by: Razvan Deaconescu <[email protected]>
Add `README.maintainers.md`. This contains common instruction for setting up, configuring, building, running, using and testing applications stored in subdirectories. Specific instructions are to be handled by individual `README.md` file in each application / example subdirectory. Currently, instructions are used for binary compatible (bincompat) applications. Signed-off-by: Razvan Deaconescu <[email protected]>
Introduce Python3 as binary compatibility starting an HTTP server. Extract / Install Python using `Dockerfile`. Then run it with the `base` kernel images from `../../kernels/`. Add typical files for a bincompat app: * `Kraftfile`: build / run rules, including pulling the `base` image * `Dockerfile`: filesystem, including binary and libraries * `Makefile`: used to generate the root filesystem from the `Dockerfile` rules * `README.md`: instructions to set up, build and run the application * `config.yaml`: configuration file to generate scripts to the application * `server.py`: Python script to start an HTTP server `config.yaml` is used to generate run scripts using the `../../utils/bincompat/generate.py` script. The kernels in `../../kernels` are generated by running the `../../utils/bincompat/base-build-all.sh` script while inside the `../../library/base/` directory. Signed-off-by: Razvan Deaconescu <[email protected]>
d566fb0
to
c2f1944
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good, thanks.
Approved-by: Stefan Jumarea [email protected]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good.
Reviewed-by: Mihnea Firoiu [email protected]
Introduce Python3 as binary compatibility runstarting an HTTP server. Extract / Install Python using
Dockerfile
. Then run it with thebase
kernel images from../../kernels/
.Add typical files for a bincompat app:
Kraftfile
: build / run rules, including pulling thebase
imageDockerfile
: filesystem, including binary and librariesMakefile
: used to generate the root filesystem from theDockerfile
rulesREADME.md
: instructions to set up, build and run the applicationconfig.yaml
: configuration file to generate scripts to the applicationserver.py
: Python script to start an HTTP serverconfig.yaml
is used to generate run scripts using the../../utils/bincompat/generate.py
script.The kernels in
../../kernels
are generated by running the../../utils/bincompat/base-build-all.sh
script while inside the../../library/base/
directory.