Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Redis app #23

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add Redis app #23

wants to merge 1 commit into from

Conversation

spx01
Copy link

@spx01 spx01 commented Dec 5, 2024

Add redis directory:

  • rootfs/redis.conf: Redis configuration file
  • Config.uk: application configuration
  • Makefile: for building the application
  • Makefile.uk: empty placeholder file required by build system
  • fc.x86_64.json / fc.arm64.json: Firecracker configuration
  • xen.x86_64.cfg / xen.arm64.cfg: Xen configuration
  • README.md: instructions
  • .gitignore: ignore generated files
  • NOTES.md: notes for QEMU compatibility

Addresses #6

- `rootfs/redis.conf`: Redis configuration file
- `Config.uk`: application configuration
- `Makefile`: for building the application
- `Makefile.uk`: empty placeholder file required by build system
- `fc.x86_64.json` / `fc.arm64.json`: Firecracker configuration
- `xen.x86_64.cfg` / `xen.arm64.cfg`: Xen configuration
- `README.md`: instructions
- `.gitignore`: ignore generated files
- `NOTES.md`: notes for QEMU compatibility

Signed-off-by: spx01 <[email protected]>
@spx01 spx01 marked this pull request as ready for review December 5, 2024 23:43
@spx01 spx01 marked this pull request as draft December 5, 2024 23:44
Copy link
Contributor

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments.

Update README.md with the updated structure and contet of README.md files in the repository (such as the README.md file for nginx). See the commit history - look for commits with the apps/README.md prefix.

Comment on lines +1 to +2
# Configure Redis server application for a build that uses initrd to pass the root
# filesystem and a bridge networking.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rephrase to: " Configure Redis server application for a build with bridged networking and using initrd to pass the root filesystem."

@@ -0,0 +1,15 @@
**2024-09-20**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is no longer the case since Unikraft release v0.18.0 (Helene).

@@ -0,0 +1,515 @@
# Redis on Unikraft

Build and run Redis on Unikraft.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Build and run Redis on Unikraft.
Build and run [Redis](https://redis.io/) on Unikraft.

@razvand razvand self-assigned this Dec 27, 2024
@razvand razvand added the enhancement New feature or request label Dec 27, 2024
Copy link
Contributor

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a first commit line named: Introduce Redis. Then add a blank line in the commit message, then add the other contents.

Use redis/ instead of redis (for directory name).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants