Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nuke _member_ role requirement #37

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Nuke _member_ role requirement #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions pkg/providers/openstack/provider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,14 +313,14 @@ func (p *Provider) Images(ctx context.Context) (providers.ImageList, error) {
for i := range resources {
image := &resources[i]

kuebernetesVersion, _ := image.Properties["k8s"].(string)
kubernetesVersion, _ := image.Properties["k8s"].(string)

result = append(result, providers.Image{
ID: image.ID,
Name: image.Name,
Created: image.CreatedAt,
Modified: image.UpdatedAt,
KubernetesVersion: semver(kuebernetesVersion),
KubernetesVersion: semver(kubernetesVersion),
})
}

Expand Down Expand Up @@ -393,10 +393,7 @@ func (p *Provider) getRequiredRoles() []string {
return p.region.Spec.Openstack.Identity.ClusterRoles
}

// TODO: _member_ shouldn't be necessary, delete me when we get a hsndle on it.
// This is quired by Octavia to list providers and load balancers at the very least.
defaultRoles := []string{
"_member_",
"member",
"load-balancer_member",
}
Expand Down
Loading