Make Regions Organization Scoped #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After playing with the UI, it semms quite apparent that mapping a region ID to a name, when the region is itself project scoped is quite heavy weight and unwieldy. To remedy this we move regions back to the organization scope so we need only a single lookup, relying on RBAC information to do any filtering. This also splits up regions and instrastructure so readers can map to regions, but not create identities etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After playing with the UI, it semms quite apparent that mapping a region ID to a name, when the region is itself project scoped is quite heavy weight and unwieldy. To remedy this we move regions back to the organization scope so we need only a single lookup, relying on RBAC information to do any filtering. This also splits up regions and instrastructure so readers can map to regions, but not create identities etc.