refactor: use constants to get forgeFactory address #355

peterjah · 2021-10-15T09:23:34Z

No description provided.

codecov · 2021-10-15T09:26:35Z

Codecov Report

Merging #355 (40b35c4) into develop (c491880) will decrease coverage by 0.03%.
The diff coverage is 15.38%.

@@             Coverage Diff             @@
##           develop     #355      +/-   ##
===========================================
- Coverage    58.89%   58.86%   -0.04%     
===========================================
  Files          531      531              
  Lines        15092    15104      +12     
  Branches      2182     2185       +3     
===========================================
+ Hits          8889     8891       +2     
- Misses        6157     6167      +10     
  Partials        46       46

Flag	Coverage Δ
functional	`26.82% <15.38%> (-0.01%)`	⬇️
unit	`44.54% <15.38%> (-0.03%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
plugins/uns/uns-crypto/src/crypto/uns-crypto.ts	`0.00% <0.00%> (ø)`
...uns/uns-transactions/src/handlers/utils/helpers.ts	`59.70% <22.22%> (-5.82%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c491880...40b35c4. Read the comment docs.

dlecan

Please, no hardcoded addresses

dlecan · 2021-10-19T07:39:30Z

plugins/uns/uns-crypto/src/crypto/uns-crypto.ts

+        switch (network) {
+            case "dalinet":
+                if (tokenId === "5f96dd359ab300e2c702a54760f4d74a11db076aa17575179d36e06d75c96511") {
+                    return "DTRnY3JjFpAnCX1nFtF8M4v8X7WdvPYRxb";
+                }
+                break;
+            case "sandbox":
+                if (tokenId === "ed4eaa7299284ac4c0665d2edecc3064a33134566d94e6ffceebc1ab32251a04") {
+                    return "SYD1xMGubmzW1qme18yxmVhpWxpoBJqv2v";
+                }
+
+                if (tokenId === "8ddab07ee0f49c76db32018a9305d7634264c39a89317f68a8069c161f4b8ec6") {
+                    return "Scms9QGQnSe7SGegVAa61dR2GTUTa586R1";
+                }
+                break;
+            case "livenet":
+                if (tokenId === "fbfbe7d9e8c005f1a9937d9fd17c4ef7da2ff8037a71e6cb7847b302eda4d08a") {
+                    return "USLEkzoncHwRdNyPVTPNJSjRXt6pYHzk43";
+                }
+                if (tokenId === "8bdd3a5358a8c6e0d96796048a87a8d83d076c73f52a0b850575e95f192376f9") {
+                    return "UYcNuMK46RdFyGVmwrT3i11W16fE5N59j4";
+                }
+                break;
+        }
+        return undefined;


Just use a Map for that
If the key is missing, look for it in the DB and add the result to the Map

dlecan · 2021-10-19T07:43:41Z

plugins/uns/uns-crypto/src/crypto/uns-crypto.ts

+    // This little hack is intended to reduce the call to the nft database.
+    // We call getUnikOwnerAddress of forgefactory at every certified transactions, especially at core bootstrap.
+    // Its imply that forge factory NFT should not be transferable
+    public getForgeFactoryAddress(tokenId: string): string | undefined {
