fix: nft mint properties bootstrap

unik-name · Oct 18, 2021 · cfbb608 · cfbb608
1 parent 0afbb57
commit cfbb608
Show file tree

Hide file tree

Showing 6 changed files with 19 additions and 9 deletions.
diff --git a/__tests__/integration/uns/certified-nft-mint-v2.test.ts b/__tests__/integration/uns/certified-nft-mint-v2.test.ts
@@ -12,6 +12,7 @@ import * as NftSupport from "../../functional/transaction-forging/__support__/nf
 import { NFTTransactionFactory } from "../../helpers/nft-transaction-factory";
 import * as Fixtures from "../../unit/uns-crypto/__fixtures__/index";
 import genesisBlock from "../../utils/config/dalinet/genesisBlock.json";
+import { formatProperties } from "./utils";
 
 let walletManager: WalletManager;
 let database: Database.IDatabaseService;
@@ -65,8 +66,8 @@ describe("certifiedNftMint handler tests for token eco v2", () => {
 
     it("wallet bootstrap for mint transaction", async () => {
         const properties = {
-            type: DIDTypes.INDIVIDUAL.toString(),
             [LIFE_CYCLE_PROPERTY_KEY]: LifeCycleGrades.MINTED.toString(),
+            type: DIDTypes.INDIVIDUAL.toString(),
         };
         const serviceCost = Utils.BigNumber.make(654321);
         const fee = 12345;
@@ -99,16 +100,18 @@ describe("certifiedNftMint handler tests for token eco v2", () => {
 
         expect(Object.keys(senderWallet.getAttribute("tokens")).includes(tokenId)).toBeTrue();
         expect(await nftManager.exists(tokenId)).toBeTrue();
+
+        expect(await nftRepository().findProperties(tokenId)).toEqual(formatProperties(properties));
     });
 
     it("wallet bootstrap for individual mint transaction with voucher", async () => {
         const voucherId = "6trg50ZxgEPl9Av8V67c0";
         const serviceCost = Utils.BigNumber.ZERO;
         const fee = 0;
         const properties = {
-            type: DIDTypes.INDIVIDUAL.toString(),
-            UnikVoucherId: voucherId,
             [LIFE_CYCLE_PROPERTY_KEY]: LifeCycleGrades.MINTED.toString(),
+            UnikVoucherId: voucherId,
+            type: DIDTypes.INDIVIDUAL.toString(),
         };
         const transaction = NFTTransactionFactory.nftCertifiedMint(
             tokenId,
@@ -138,6 +141,7 @@ describe("certifiedNftMint handler tests for token eco v2", () => {
 
         expect(Object.keys(senderWallet.getAttribute("tokens")).includes(tokenId)).toBeTrue();
         expect(await nftManager.exists(tokenId)).toBeTrue();
+        expect(await nftRepository().findProperties(tokenId)).toEqual(formatProperties(properties));
     });
 
     it("wallet bootstrap for organization mint transaction with voucher", async () => {
@@ -149,9 +153,9 @@ describe("certifiedNftMint handler tests for token eco v2", () => {
         const fee = rewards.forger;
 
         const properties = {
-            type: didType.toString(),
-            UnikVoucherId: voucherId,
             [LIFE_CYCLE_PROPERTY_KEY]: LifeCycleGrades.MINTED.toString(),
+            UnikVoucherId: voucherId,
+            type: didType.toString(),
         };
         const transaction = NFTTransactionFactory.nftCertifiedMint(
             tokenId,
@@ -180,5 +184,6 @@ describe("certifiedNftMint handler tests for token eco v2", () => {
 
         expect(Object.keys(senderWallet.getAttribute("tokens")).includes(tokenId)).toBeTrue();
         expect(await nftManager.exists(tokenId)).toBeTrue();
+        expect(await nftRepository().findProperties(tokenId)).toEqual(formatProperties(properties));
     });
 });
diff --git a/__tests__/integration/uns/certified-nft-mint.test.ts b/__tests__/integration/uns/certified-nft-mint.test.ts
@@ -11,6 +11,7 @@ import * as NftSupport from "../../functional/transaction-forging/__support__/nf
 import { NFTTransactionFactory } from "../../helpers/nft-transaction-factory";
 import * as Fixtures from "../../unit/uns-crypto/__fixtures__/index";
 import genesisBlock from "../../utils/config/dalinet/genesisBlock.json";
+import { formatProperties } from "./utils";
 
 let walletManager: WalletManager;
 let database: Database.IDatabaseService;
@@ -94,6 +95,7 @@ describe("certifiedNftMint handler tests", () => {
 
         expect(Object.keys(senderWallet.getAttribute("tokens")).includes(tokenId)).toBeTrue();
         expect(await nftManager.exists(tokenId)).toBeTrue();
+        expect(await nftRepository().findProperties(tokenId)).toEqual(formatProperties(properties));
     });
 
     it("wallet bootstrap for mint transaction with voucher", async () => {
@@ -103,8 +105,8 @@ describe("certifiedNftMint handler tests", () => {
         const rewards = getRewardsFromDidType(didType);
 
         const properties = {
-            type: didType.toString(),
             UnikVoucherId: voucherId,
+            type: didType.toString(),
         };
 
         const transaction = NFTTransactionFactory.nftCertifiedMint(
@@ -135,5 +137,6 @@ describe("certifiedNftMint handler tests", () => {
 
         expect(Object.keys(senderWallet.getAttribute("tokens")).includes(tokenId)).toBeTrue();
         expect(await nftManager.exists(tokenId)).toBeTrue();
+        expect(await nftRepository().findProperties(tokenId)).toEqual(formatProperties(properties));
     });
 });
diff --git a/__tests__/integration/uns/certified-nft-update.test.ts b/__tests__/integration/uns/certified-nft-update.test.ts
@@ -12,6 +12,7 @@ import * as NftSupport from "../../functional/transaction-forging/__support__/nf
 import { NFTTransactionFactory } from "../../helpers/nft-transaction-factory";
 import * as Fixtures from "../../unit/uns-crypto/__fixtures__/index";
 import genesisBlock from "../../utils/config/dalinet/genesisBlock.json";
+import { formatProperties } from "./utils";
 
 let walletManager: WalletManager;
 let database: Database.IDatabaseService;
@@ -190,5 +191,3 @@ describe("certifiedNftupdate handler tests", () => {
         expect(await nftRepo.findProperties(Fixtures.tokenId)).toEqual(formatProperties(properties));
     });
 });
-
-const formatProperties = props => Object.entries(props).map(([key, val]) => ({ key, value: val }));
diff --git a/__tests__/integration/uns/utils.ts b/__tests__/integration/uns/utils.ts
@@ -0,0 +1 @@
+export const formatProperties = props => Object.entries(props).map(([key, val]) => ({ key, value: val }));
diff --git a/plugins/nft/nft-transactions/src/transactions/handlers/nft-mint.ts b/plugins/nft/nft-transactions/src/transactions/handlers/nft-mint.ts
@@ -44,6 +44,7 @@ export class NftMintTransactionHandler extends Handlers.TransactionHandler {
 
                 // Save changes in database
                 await applyNftMintDb(transaction.senderPublicKey, transaction.asset);
+                await applyProperties(transaction.asset);
             }
         }
     }

diff --git a/plugins/uns/uns-transactions/src/handlers/uns-certified-nft-mint.ts b/plugins/uns/uns-transactions/src/handlers/uns-certified-nft-mint.ts
@@ -1,7 +1,7 @@
 import { Database, State } from "@arkecosystem/core-interfaces";
 import { Handlers, Interfaces as TrxInterfaces, TransactionReader } from "@arkecosystem/core-transactions";
 import { Interfaces, Managers, Transactions, Utils } from "@arkecosystem/crypto";
-import { addNftToWallet, applyNftMintDb, NftMintTransactionHandler } from "@uns/core-nft";
+import { addNftToWallet, applyNftMintDb, applyProperties, NftMintTransactionHandler } from "@uns/core-nft";
 import { getCurrentNftAsset } from "@uns/core-nft-crypto";
 import {
     applyMixins,
@@ -57,6 +57,7 @@ export class CertifiedNftMintTransactionHandler extends NftMintTransactionHandle
 
                 // Save changes in database
                 await applyNftMintDb(transaction.senderPublicKey, transaction.asset);
+                await applyProperties(transaction.asset);
             }
         }
     }