runtime: Make "mono" select a monospaced font. #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jafaral
reviewed
Feb 10, 2024
src/runtime/rmswin.ri
Outdated
| @@ -1674,10 +1674,14 @@ HFONT mkfont(char *s, char is_3D) | |||
| * This is a legal Icon font spec. | |||
| * Check first for special "standard" family names. | |||
| */ | |||
| if (!strcmp(family, "mono") || !strcmp(family, "fixed")) { | |||
| stdfam = "Lucida Sans"; /* Lucida Console? */ | |||
| if (!strcmp(family, "mono")) { | |||
There was a problem hiding this comment.
That willl be the tabs (sigh). OK, I'll fix it. There are are times (most of the time, actually) when I wish we could replace every tab in the source code with spaces.
Jafaral
reviewed
Feb 10, 2024
src/runtime/rxwin.ri
Outdated
| @@ -5698,10 +5698,14 @@ void mkfont(char *s, char is_3D) | |||
| * This is a legal Icon font spec. | |||
| * Check first for special "standard" family names. | |||
| */ | |||
| if (!strcmp(family, "mono") || !strcmp(family, "fixed")) { | |||
| stdfam = "Lucida Sans"; /* Lucida Console? */ | |||
| if (!strcmp(family, "mono")) { | |||
Don-Ward
force-pushed
the
monospace-font
branch
2 times, most recently
from
e607a9d to
5149743
Compare
Previously, "mono" and "fixed" were treated as the same thing and asked for Lucida Sans, which is a proportionally spaced font. Now, "mono" asks for Lucida Console, which is monospaced, and "fixed" selects Lucida Sans (with the correct flags).
Don-Ward
force-pushed
the
monospace-font
branch
from
5149743 to
5978b26
Compare
Jafaral
approved these changes
Feb 12, 2024
ValG4
pushed a commit
to ValG4/unicon
that referenced
this pull request
Dec 7, 2024
runtime: Make "mono" select a monospaced font.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, "mono" and "fixed" were treated as the same thing and asked for Lucida Sans, which is a proportionally spaced font. Now, "mono" asks for Lucida Console, which is monospaced, and "fixed" selects Lucida Sans (with the correct flags).