Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UCD 17 draft Blocks bugs #986

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Conversation

markusicu
Copy link
Member

fix bugs reported in ReportID: ID20241210012540 / PAG issue 356

@eggrobin
Copy link
Member

Blocks.txt should really be regenerated, that would at least solve the sorting issue.

We should probably also test that blocks start in 0 and end in F.

@markusicu
Copy link
Member Author

We should probably also test that blocks start in 0 and end in F.

@markusicu
Copy link
Member Author

@eggrobin I am now getting the same NPE that you are working on in your PR. Ok if I ignore it here?

Error:  Tests run: 4, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 38.871 s <<< FAILURE! - in org.unicode.text.UCD.TestTestUnicodeInvariants
Error:  org.unicode.text.UCD.TestTestUnicodeInvariants.testAdditionComparisons  Time elapsed: 0.001 s  <<< ERROR!
java.lang.NullPointerException
	at org.unicode.text.UCD.TestTestUnicodeInvariants.testAdditionComparisons(TestTestUnicodeInvariants.java:47)

@eggrobin
Copy link
Member

I am now getting the same NPE that you are working on in your PR. Ok if I ignore it here?

Yes, please ignore it (and I eventually fixed it in the other PR, so go approve that one :-p)

@markusicu markusicu merged commit 7233d4b into unicode-org:main Dec 11, 2024
14 of 16 checks passed
@markusicu markusicu deleted the fix-blocks branch December 11, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants