Ucdxml 17v1 #1104

jowilco · 2025-04-25T00:17:05Z

Addresses https://www.unicode.org/L2/L2019/19270.htm#160-A10 by consuming the RegEx syntax for Unihan directly from UAX38.
Resolved https://www.unicode.org/L2/L2024/24221.htm#181-A43 by removing kGB7.
Resolved https://www.unicode.org/L2/L2024/24221.htm#181-A131 by updating the RegEx for the na attribute.
Addresses https://www.unicode.org/L2/L2024/24221.htm#181-A133 by adding support for Unicode Version 17.0
Resolved https://www.unicode.org/L2/L2025/25085.htm#183-A100 by removing kJa.
Resolved https://www.unicode.org/L2/L2025/25085.htm#183-A127 by adding kTayNumeric.
Resolved https://www.unicode.org/L2/L2025/25085.htm#183-A180. All Unihan syntaxes are sourced directly from UAX38.
Addresses UCDXML: add Unikemet properties #921 by adding support for Unikemet.
Resolved Update UAX42 to document that common Unihan attributes are grouped starting with Unicode 17 #1071 by adding a comment indicating that "Unihan attributes are applied at the group where applicable, similar to how non-Unihan attributes are applied at the group."
Partially addresses Update UAX42 to document which UCDXML fields correspond to UCD properties (UAX44) vs. which are “just data” corresponding to various UCD files #1049 by removing Deprecated properties, Normalization Corrections, and Emoji Sources.

…istorical data, and added partial support for kEH_AltSeq

markusicu · 2025-04-25T00:41:14Z

Hi @jowilco the CI failures suggest that you need to run GenerateEnums again, and also mvn spotless:apply.

jowilco · 2025-04-25T00:43:38Z

Hi @jowilco the CI failures suggest that you need to run GenerateEnums again, and also mvn spotless:apply.

Agreed. This is still a draft pending the fixes for TR57. I'll definitely clean everything up before removing the draft status.

markusicu · 2025-04-25T00:49:38Z

unicodetools/src/main/java/org/unicode/xml/GeneratePropertyValues.java

+//Deprecated
+//        createPropertyFragment(
+//                UcdProperty.ISO_Comment,
+//                SCHEMA.PROPERTIES,
+//                getFormattedSyntax(UcdProperty.ISO_Comment));


i suggest you just delete this altogether

markusicu · 2025-04-25T00:50:04Z

unicodetools/src/main/java/org/unicode/xml/GeneratePropertyValues.java

+//Deprecated
+//            case FC_NFKC_Closure:


i suggest you just delete this altogether

markusicu · 2025-04-25T00:51:40Z

unicodetools/src/main/java/org/unicode/xml/GeneratePropertyValues.java

+//Deprecated
+//                + TRIPLELINE
+//                + getFormattedBoolean(UcdProperty.Expands_On_NFC)
+//                + DOUBLELINE
+//                + getFormattedBoolean(UcdProperty.Expands_On_NFD)
+//                + DOUBLELINE
+//                + getFormattedBoolean(UcdProperty.Expands_On_NFKC)
+//                + DOUBLELINE
+//                + getFormattedBoolean(UcdProperty.Expands_On_NFKD)
+//                + TRIPLELINE
+//                + getFormattedSyntax(UcdProperty.FC_NFKC_Closure);


i suggest you just delete this altogether

markusicu · 2025-04-25T00:51:48Z

unicodetools/src/main/java/org/unicode/xml/GeneratePropertyValues.java

+//Deprecated
+//                + getFormattedBoolean(UcdProperty.Hyphen)
+//                + DOUBLELINE


markusicu · 2025-04-25T00:51:59Z

unicodetools/src/main/java/org/unicode/xml/GeneratePropertyValues.java

+//Deprecated
+//                + getFormattedBoolean(UcdProperty.Grapheme_Link)
+//                + DOUBLELINE


markusicu · 2025-04-25T00:54:20Z

unicodetools/src/main/java/org/unicode/xml/UCDPropertyDetail.java

+// Deprecated
+//    public static UCDPropertyDetail Hyphen_Detail =
+//            new UCDPropertyDetail(
+//                    UcdProperty.Hyphen,
+//                    VersionInfo.getInstance(2, 0, 0),
+//                    32,
+//                    true,
+//                    false,
+//                    false,
+//                    true,
+//                    false);


i suggest you just delete this altogether

I screwed up here - I should have added values for maxVersion, which I have done now.

markusicu · 2025-04-25T00:54:38Z

unicodetools/src/main/java/org/unicode/xml/UCDPropertyDetail.java

+// Deprecated
+//    public static UCDPropertyDetail Grapheme_Link_Detail =
+//            new UCDPropertyDetail(
+//                    UcdProperty.Grapheme_Link,
+//                    VersionInfo.getInstance(3, 2, 0),
+//                    59,
+//                    true,
+//                    false,
+//                    false,
+//                    true,
+//                    false);


i suggest you just delete this altogether

I screwed up here - I should have added values for maxVersion, which I have done now.

markusicu · 2025-04-25T00:54:53Z

unicodetools/src/main/java/org/unicode/xml/UCDPropertyDetail.java

-                    true);
-    public static UCDPropertyDetail Expands_On_NFD_Detail =
+                    false);
+// Deprecated


i suggest you just delete this altogether

I screwed up here - I should have added values for maxVersion, which I have done now.

markusicu · 2025-04-25T00:55:30Z

unicodetools/src/main/java/org/unicode/xml/UCDPropertyDetail.java

-                    false,
-                    true);
+                    false);
+//    public static UCDPropertyDetail kGB7_Detail =


i suggest you just delete this altogether

markusicu · 2025-04-25T00:56:08Z

unicodetools/src/main/java/org/unicode/xml/UCDPropertyDetail.java

-                    false,
-                    true);
+                    false);
+// Deprecated


i suggest you just delete this altogether

I screwed up here - I should have added values for maxVersion, which I have done now.

…istorical data, and added partial support for kEH_AltSeq

jowilco added 8 commits March 31, 2025 12:28

Initial checkin to support Unikemet

c46e7ef

Added note about grouping Unihan attributes, and more work for Unikemet

230f01e

Merge branch 'main' into ucdxml_17v1

e19c289

Fixed merge conflict

9592302

Merge branch 'main' into ucdxml_17v1

4d3d207

Removed Deprecated properties, removed sections that only contained h…

dbec10c

…istorical data, and added partial support for kEH_AltSeq

Updated version information

c96704b

Renamed index to tr42 to make it easier to copy to unicode-reports

83224c0

jowilco marked this pull request as draft April 25, 2025 00:17

jowilco requested a review from markusicu April 25, 2025 00:17

markusicu self-assigned this Apr 25, 2025

markusicu requested review from eggrobin, nedley, josh-hadley and Ken-Whistler April 25, 2025 00:36

markusicu reviewed Apr 25, 2025

View reviewed changes

jowilco added 12 commits April 29, 2025 10:24

Added removed/changed support

09e5ce9

Initial checkin to support Unikemet

3a6fa48

Added note about grouping Unihan attributes, and more work for Unikemet

f067ad8

Removed Deprecated properties, removed sections that only contained h…

8f968de

…istorical data, and added partial support for kEH_AltSeq

Updated version information

65041e5

Renamed index to tr42 to make it easier to copy to unicode-reports

e725fe4

Added removed/changed support

16ba5f0

Merge conflict

a122cc6

Removed commented lines

48fc787

Removed commented lines

9ed79b4

Set maxVersion for kGB7

0fb10c5

kGB7 is a removed property

2037df8

kGB7 is a removed property

f75893e

jowilco changed the base branch from main to trunk April 29, 2025 18:08

jowilco changed the base branch from trunk to main April 29, 2025 18:08

jowilco added 5 commits April 29, 2025 11:14

GenerateEnums and mvn spotless

8dfe8d2

Updated with latest UCD changes

599b253

Latest TR38 changes

f1e6058

Merged main

902ba5c

Latest Unihan, Tangut, and Nushu changes

7d24164

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ucdxml 17v1 #1104

Ucdxml 17v1 #1104

jowilco commented Apr 25, 2025 •

edited

Loading

markusicu commented Apr 25, 2025

jowilco commented Apr 25, 2025

markusicu Apr 25, 2025

jowilco Apr 29, 2025

markusicu Apr 25, 2025

jowilco Apr 29, 2025

markusicu Apr 25, 2025

jowilco Apr 29, 2025

markusicu Apr 25, 2025

jowilco Apr 29, 2025

markusicu Apr 25, 2025

jowilco Apr 29, 2025

markusicu Apr 25, 2025

jowilco Apr 29, 2025

markusicu Apr 25, 2025

jowilco Apr 29, 2025

markusicu Apr 25, 2025

jowilco Apr 29, 2025

markusicu Apr 25, 2025

markusicu Apr 25, 2025

jowilco Apr 29, 2025

Ucdxml 17v1 #1104

Are you sure you want to change the base?

Ucdxml 17v1 #1104

Conversation

jowilco commented Apr 25, 2025 • edited Loading

markusicu commented Apr 25, 2025

jowilco commented Apr 25, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jowilco commented Apr 25, 2025 •

edited

Loading