Skip to content

Move provider/core to no_std #870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jul 21, 2021
Merged

Conversation

Manishearth
Copy link
Member

Progress on #812

Using the awk script in #812 (comment)

@Manishearth Manishearth requested review from nciric, sffc, zbraniecki and a team as code owners July 21, 2021 00:17
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • components/locid/Cargo.toml is no longer changed in the branch
  • components/locid/src/extensions/mod.rs is no longer changed in the branch
  • components/locid/src/extensions/private/key.rs is no longer changed in the branch
  • components/locid/src/extensions/private/mod.rs is no longer changed in the branch
  • components/locid/src/extensions/transform/fields.rs is no longer changed in the branch
  • components/locid/src/extensions/transform/key.rs is no longer changed in the branch
  • components/locid/src/extensions/transform/mod.rs is no longer changed in the branch
  • components/locid/src/extensions/transform/value.rs is no longer changed in the branch
  • components/locid/src/extensions/unicode/attribute.rs is no longer changed in the branch
  • components/locid/src/extensions/unicode/attributes.rs is no longer changed in the branch
  • components/locid/src/extensions/unicode/key.rs is no longer changed in the branch
  • components/locid/src/extensions/unicode/keywords.rs is no longer changed in the branch
  • components/locid/src/extensions/unicode/mod.rs is no longer changed in the branch
  • components/locid/src/extensions/unicode/value.rs is no longer changed in the branch
  • components/locid/src/helpers.rs is no longer changed in the branch
  • components/locid/src/langid.rs is no longer changed in the branch
  • components/locid/src/lib.rs is no longer changed in the branch
  • components/locid/src/locale.rs is no longer changed in the branch
  • components/locid/src/parser/errors.rs is no longer changed in the branch
  • components/locid/src/parser/langid.rs is no longer changed in the branch
  • components/locid/src/serde/langid.rs is no longer changed in the branch
  • components/locid/src/subtags/language.rs is no longer changed in the branch
  • components/locid/src/subtags/region.rs is no longer changed in the branch
  • components/locid/src/subtags/script.rs is no longer changed in the branch
  • components/locid/src/subtags/variant.rs is no longer changed in the branch
  • components/locid/src/subtags/variants.rs is no longer changed in the branch
  • utils/fixed_decimal/benches/fixed_decimal.rs is no longer changed in the branch
  • utils/fixed_decimal/Cargo.toml is different
  • utils/fixed_decimal/src/decimal.rs is no longer changed in the branch
  • utils/fixed_decimal/src/lib.rs is no longer changed in the branch
  • utils/fixed_decimal/src/uint_iterator.rs is no longer changed in the branch
  • utils/yoke/src/yokeable.rs is no longer changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

sffc
sffc previously approved these changes Jul 21, 2021
@@ -37,7 +38,8 @@ icu_locid = { version = "0.2", path = "../../components/locid" }
tinystr = { version = "0.4.10", features = ["alloc"], default-features = false }
writeable = { version = "0.2", path = "../../utils/writeable" }
displaydoc = { version = "0.2.3", default-features = false }
yoke = { version = "0.2", path = "../../utils/yoke", features = ["serde", "derive"] }
yoke = { version = "0.2.1", path = "../../utils/yoke", features = ["serde", "derive"] }
litemap = { path = "../../utils/litemap", version = "0.2.1", features = ["serde"]}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I don't think you need litemap serde

@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2021

Codecov Report

Merging #870 (91aa9ba) into main (ff56a70) will increase coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #870      +/-   ##
==========================================
+ Coverage   74.30%   74.32%   +0.01%     
==========================================
  Files         206      206              
  Lines       13038    13042       +4     
==========================================
+ Hits         9688     9693       +5     
+ Misses       3350     3349       -1     
Impacted Files Coverage Δ
provider/core/src/data_provider/test.rs 91.86% <ø> (ø)
provider/core/src/dynutil.rs 38.88% <ø> (-1.12%) ⬇️
provider/core/src/erased.rs 82.88% <0.00%> (ø)
provider/core/src/error.rs 4.16% <ø> (ø)
provider/core/src/filter/impls.rs 0.00% <ø> (ø)
provider/core/src/filter/mod.rs 6.45% <ø> (ø)
provider/core/src/hello_world.rs 80.00% <0.00%> (ø)
provider/core/src/inv.rs 0.00% <ø> (ø)
provider/core/src/iter.rs 0.00% <ø> (ø)
provider/core/src/lib.rs 100.00% <ø> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff56a70...91aa9ba. Read the comment docs.

@coveralls
Copy link

coveralls commented Jul 21, 2021

Pull Request Test Coverage Report for Build 9d98324d03af69af62a346147ce44b66df5d3dea-PR-870

  • 8 of 12 (66.67%) changed or added relevant lines in 5 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 74.385%

Changes Missing Coverage Covered Lines Changed/Added Lines %
provider/core/src/erased.rs 0 1 0.0%
provider/core/src/hello_world.rs 0 1 0.0%
provider/core/src/resource.rs 3 4 75.0%
provider/core/src/serde.rs 3 4 75.0%
Files with Coverage Reduction New Missed Lines %
provider/core/src/dynutil.rs 1 38.89%
Totals Coverage Status
Change from base Build ff56a70f588b63f134714956a8eb8e1ee37a99d3: 0.02%
Covered Lines: 9824
Relevant Lines: 13207

💛 - Coveralls

@Manishearth Manishearth merged commit 09d5aef into unicode-org:main Jul 21, 2021
@Manishearth Manishearth deleted the provider-nostd branch February 3, 2022 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants