Data-driven e2e tests

[echeran]

This isn't complete (hence Draft PR), but I could use feedback, even on Rust basics (ex: code organization, module declarations).

[echeran]

Also, have people used type aliases with SerDe? serde::json maps structs to JSON objects, which makes sense, but what if I want to define a locale subtag as Vec<String>?

There is also the separate question of whether defining a locale subtag as Vec<String> is the right choice -- also open to discussion on that, etc.

[zbraniecki]

Would it be useful to add serde serializer/deserializer as a feature for locale like zbraniecki/unic-locale@1450d0a ?

[sffc]

Should these go in a common shared crate instead? #88

[echeran]

Ah, I see what you're saying. Yes, I agree. I left my comments in the issue.

[echeran]

Would it be useful to add serde serializer/deserializer as a feature for locale like zbraniecki/unic-locale@1450d0a ?

Hmm, I think I understand, and yes that makes sense. IIUC, then that would make some of the E2E tests for Locale look like: JSON test data's input -> SerDe -> structured test data -> runner -> Locale API -> Locale, and then maybe have JSON test data's exp output -> SerDe -> Locale, and then compare.

[sffc]

I'm not sure if we want serde to be merely a feature. It seems like a core piece of functionality when it comes to the data pipeline.

[echeran]

I have a commit to make Locale serializable just like LanguageIdentifier (shameless mimicking for now). In the process of doing that, I noticed that some of the tests are brittle -- testing error conditions require use the exact error message. If we have specific error types in the future, then that can be made less brittle.

[coveralls]

Pull Request Test Coverage Report for Build 19669b18f620d505037fc6863d92afb51bd011e4-PR-86

• 194 of 203 (95.57%) changed or added relevant lines in 5 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+3.2%) to 90.423%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
components/e2etests/src/lib.rs	14	16	87.5%
components/locale/src/serde/locale.rs	51	54	94.44%
components/e2etests/src/runner/runner.rs	42	46	91.3%

Totals
Change from base Build 24f4b5d15940198185fe7cf8fc0e90b80b9583b5:	3.2%
Covered Lines:	897
Relevant Lines:	992

---

💛 - Coveralls

[sffc]

This should be tied in with #177. This will let you load the test data from the new /data top-level directory. I don't think we should move forward on this PR until I have a solution to #177 checked in. I will try to get that ASAP to unblock your work.

[zbraniecki]

You can use serde_json::json macro - https://docs.serde.rs/serde_json/macro.json.html

[sffc]

Just revisiting this PR.

Here's one model you could adopt: first, an IterableDataProvider that exports golden test data, and second, a unit test that checks that the current library output is consistent with the golden data. I expect that you can share most of the code between the golden data generator and the unit test framework.

We should put our heads together and come up with a model that makes sense. For now, I'm going to switch this PR back to draft.